search

flathub-infra / flatpak-external-data-checker

A tool for checking if the external data used in Flatpak manifests is still up to date
GNU General Public License v2.0
116 stars 34 forks source link

manifest: Add module name of changed data in commit message #428

Closed bbhtt closed 1 month ago

bbhtt commented 1 month ago

name is a required property, and is checked by jsonschema. It can be None when someone sets it to empty like - name:, in that case, they are on their own.

I don't think I need to handle the None case separately.

wjt commented 1 month ago

name is a required property, and is checked by jsonschema.

Where do you see this check? I don't see any uses of jsonschema to check the manifest as a whole, only the x-checker-data blocks on a per-checker basis.

gasinvein commented 1 month ago

name is a required property, and is checked by jsonschema.

Where do you see this check? I don't see any uses of jsonschema to check the manifest as a whole, only the x-checker-data blocks on a per-checker basis.

I believe f-e-d-c will fail to load a module without the name property (with an unhandled KeyError exception) here

https://github.com/flathub-infra/flatpak-external-data-checker/blob/bf14aa11b4bc50e3b7ba54e74009f1f6a5212454/src/lib/externaldata.py#L73-L84