search

flathub-infra / ide-flatpak-wrapper

Wrapper for setting up development environment in flatpak sandbox
MIT License
14 stars 12 forks source link

Add a shell-wrapper file #20

Open blt-r opened 10 months ago

blt-r commented 10 months ago

In helix, there's no integrated terminal in the editor. So it isn't possible to have a shell session in the environment set up by the wrapper. In this PR, I added a shell-wrapper (maybe another name would be better) executable into /app/bin that just sets up the environment and launches bash. Users will be able to flatpak run --command=shell-wrapper com.helix_editor.Helix, and have the packages isolated, so that they can, for example, pip install packages.

To do that, I separated the logic of setting up the environment into wrapper.sh which is installed into /app/lib/ide-flatpak-wrapper/wrapper.sh and is sourced from editor.sh and shell_wrapper.sh. I also added the -Dshell_wrapper_name option to set the name of the shell_wrapper.sh executable (defaults to shell-wrapper).

CleoMenezesJr commented 9 months ago

That's great!! Would help a lot to Neovim too!