search

flathub-infra / ide-flatpak-wrapper

Wrapper for setting up development environment in flatpak sandbox
MIT License
14 stars 12 forks source link

Adding a switch for Wayland #22

Open ghost opened 6 months ago

ghost commented 6 months ago

Continuing from https://github.com/flathub/com.vscodium.codium/pull/295 I would like to discuss the details of implementing support for Wayland here.

sr66139p commented 6 months ago

I came here from that same issue. Wayland works perfectly fine for me when running this command: flatpak run com.vscodium.codium --enable-features=UseOzonePlatform,WaylandWindowDecorations --ozone-platform=wayland, but it is annoying using the terminal every time and if you disable X11 in flatseal, even if you enable fallback X11, no window will pop up. It seems like the only work that needs to be done for Wayland is to have it come enabled by default (with Wayland window decorations). Unfortunately, it's not as easy as just adding the arguments to the desktop file as this breaks VSCodium on Xorg. I remember that VSCodium used to open in a Wayland native window at some point last year, but it lacked window decorations (at least on Gnome https://github.com/flathub/com.vscodium.codium/issues/221) and had mouse cursor scaling issues. Now that the Chromium embedded framework/Electron have better Wayland support, we might be able to just re implement whatever allowed us to open a Wayland native window last year, and we would just have to figure out how to have Wayland window decorations enabled by default.

noonsleeper commented 6 months ago

@larina3315 & @sr66139p I'm currently working to support wayland on a clean way

noonsleeper commented 5 months ago

Well @larina3315 & @sr66139p I found that the latest build of codium doesn't complain about the --enable-features=WaylandWindowDecorations arg when you start on X11 like in the past, then we don't need to modify this wrapper at all.

sr66139p commented 5 months ago

I forgot to mention this before, but the latest version of the VSCodium Flatpak works perfectly in my Wayland session since the last update, and I made sure everything is Flatseal was set to default. Title bars (both native and custom), cursors, and everything everything else works. Thanks for the good work @noonsleeper

noonsleeper commented 5 months ago

I forgot to mention this before, but the latest version of the VSCodium Flatpak works perfectly in my Wayland session since the last update, and I made sure everything is Flatseal was set to default. Title bars (both native and custom), cursors, and everything everything else works. Thanks for the good work @noonsleeper

You are welcome! :smile: