search

flathub-infra / ide-flatpak-wrapper

Wrapper for setting up development environment in flatpak sandbox
MIT License
14 stars 12 forks source link

:hammer: Wayland support for electron apps #23

Closed noonsleeper closed 3 months ago

noonsleeper commented 6 months ago

if socket=wayland is active the parameters to handle wayland decorations is set also ozone-platform-hint=auto is set

if you override with nosocket=wayland force ozone-platform=x11

daiyam commented 4 months ago

Hello @gasinvein, can you give us a timeline for this PR? Thx

gasinvein commented 4 months ago

Hello, sorry for the delay and thanks for the contribution. Sadly, I cannot test this myself atm. Did you try to build VSCod[ium] flatpak with this wrapper version and verify that it works as intended?

daiyam commented 4 months ago

Hello, sorry for the delay and thanks for the contribution. Sadly, I cannot test this myself atm. Did you try to build VSCod[ium] flatpak with this wrapper version and verify that it works as intended?

No problem. :)

The latest version should include it with the fix for KDE but I haven't test it myself... But VSCodium has been using with the PR since the March releases.

noonsleeper commented 3 months ago

Hi @gasinvein, Can you give me an update about this?

gasinvein commented 3 months ago

The zypak branch was in a WiP state, but it seems like several apps on Flathub are using it now. Do you folks consider it ready? If so, should we merge it into the main branch (see #13)?

noonsleeper commented 3 months ago

The zypak branch was in a WiP state, but it seems like several apps on Flathub are using it now. Do you folks consider it ready? If so, should we merge it into the main branch (see #13)?

I was using this since nearly the creation of the branch, and at least for codium and codium-insiders it works like a charm.