search

flathub-infra / ide-flatpak-wrapper

Wrapper for setting up development environment in flatpak sandbox
MIT License
14 stars 12 forks source link

Launch Emacs instead of VSCode #3

Closed muep closed 3 years ago

muep commented 3 years ago

Hi @gasinvein ,

I am working on adding SDK support to Emacs. Seeing what this wrapper does was my original inspiration on wanting that same thing in the Emacs flatpak, and it turns out that it pretty much already can do it.

There are some bits I would need to change, and I would like to ask if it would be preferable to just fork this repo and keep Emacs stuff out of your way, or if you would prefer to have those changes here. I am OK doing it either way, but it might be useful if the various IDE-like flatpaks handled SDK extensions similarly. At least for Jetbrains, there seems to already exist a fork of this wrapper.

gasinvein commented 3 years ago

I'm totally fine with generalizing this wrapper so it can support other editors. One thing I'd like to avoid, though, is special cases - if possible, better configure all editor-specific things as meson options.

At least for Jetbrains, there seems to already exist a fork of this wrapper.

IMO it was done without a good reason, since changes are rather minor and could've been configurable without a hard fork. But I'm not strictly against it either, especially if it proves to be necessary.

gasinvein commented 3 years ago

Is this issue resolved now?

muep commented 3 years ago

It is resolved. Thank you for the support in addressing this.