search

flathub-infra / ide-flatpak-wrapper

Wrapper for setting up development environment in flatpak sandbox
MIT License
14 stars 12 forks source link

Added option to change file extension on build time #5

Closed noonsleeper closed 3 years ago

noonsleeper commented 3 years ago

hi @gasinvein, one of the user of codium told me to check your wrapper, and after read this code I think that @proletarius101 was right, this is a good code!

gasinvein commented 3 years ago

Thanks. Although I don't understand why pass file extension as a separate option. Why not the full file name as a single option, e.g. -Dfirst_run_template=vscodium_readme.md? Ok, got it. But maybe determine target file extension automatically (based on input template) instead of passing it as an option? Or just keep the filename as it was in the option.

gasinvein commented 3 years ago

Thanks, this makes sense.