search

flathub-infra / linux-store-frontend

A web application to browse and install applications present in Flatpak repositories. Powers https://www.flathub.org
Apache License 2.0
187 stars 50 forks source link

Style: add generated shadows to app icons #222

Closed bertob closed 4 years ago

bertob commented 4 years ago

This adds a subtle shadow to icons, to improve the legibility of light icons (e.g. Boxes) on light backgrounds. We do the same thing in Software, Settings, and other places app icons are displayed.

image

jgarciao commented 4 years ago

This issue was discussed at #169 without a proper and maintainable solution. I'm inclined to merge your PR (the shadow is really soft) as your shadow is really soft

bertob commented 4 years ago

Yeah, I don't think the cases mentioned in #169 are a problem as long as the shadow is soft enough (and we do the same thing in Software/Settings/GTK already).

felipeborges commented 4 years ago

Thanks for this pull request. It was long overdue that the Boxes logo looked nice in Flathub. :)

Out of curiosity, aren't there icons with existing shadows within? Wouldn't these get a double shadow now?

bertob commented 4 years ago

Yes, but the shadow is very subtle, so it looks ok in practice.

Perhaps we should add this to the documentation/review guidlines though, so developers know not to submit icons with baked-in shadows in the future?