search

flathub-infra / linux-store-frontend

A web application to browse and install applications present in Flatpak repositories. Powers https://www.flathub.org
Apache License 2.0
187 stars 50 forks source link

Please recognise LicenseRef-proprietary case-insensitively #284

Closed smcv closed 2 years ago

smcv commented 3 years ago

Similar to https://gitlab.gnome.org/GNOME/gnome-software/-/issues/1161.

https://www.freedesktop.org/software/appstream/docs/chap-Metadata.html#tag-project_license says:

Custom licenses which are not in the SPDX registry, like proprietary licenses, can be denoted using the LicenseRef notation. LicenseRef-Proprietary can be used to denote a proprietary license, with an optional URL to the license text following after a = sign.

... but I published https://github.com/flathub/com.valvesoftware.SteamLink with LicenseRef-Proprietary as recommended there, and it shows up on Flathub with the literal text LicenseRef-Proprietary.

Other proprietary apps on Flathub (such as Steam) use LicenseRef-proprietary (which appears in an example in the Appstream spec, but not in the actual spec text), and that gets pretty-printed as Proprietary on the web page. It would be nice if the case combination from the Appstream spec was recognised in the same way.

RokeJulianLockhart commented 2 years ago

http://github.com/flathub/linux-store-frontend/issues/284#issue-820249254

I am believing that case sensitivity is not important either, although the documentation that has been mentioned should become more consistent without regard for the state of this issue.