flathub-infra / website

Monorepo with website and API
https://flathub.org
Apache License 2.0
231 stars 88 forks source link

Internal server error on /request-review API #3911

Open xytovl opened 1 month ago

xytovl commented 1 month ago

I want to request a review for io.github.wivrn.wivrn.

Developer portal doesn't show pending reviews for the app.

From https://flathub.org/apps/io.github.wivrn.wivrn web page when logged in, I click "Request review" and nothing happens on web UI.

Looking at inspector, I can see a request is done for https://flathub.org/api/v2/quality-moderation/io.github.wivrn.wivrn/request-review and fails with code 500, "Internal Server Error" and no further details.

I tried multiple times and consistently have the same error. Last attempt an 2024-09-26 16:43:37 UTC.

razzeee commented 1 month ago

The server errors, as it already has a review requested from your app. I'm curious, why you still had the UI to request one though.

xytovl commented 1 month ago

In developer portal, request https://flathub.org/api/v2/moderation/apps/io.github.wivrn.wivrn?include_handled=true&include_outdated=true&limit=10&offset=0 returns

{
    "requests": [],
    "requests_count": 0
}

Maybe the issue is related to users, I am co-author of the app, @Meumeu did the initial submission, but he has the same result in developer portal and request review.

razzeee commented 1 month ago

It should be controlled by the https://flathub.org/api/v2/quality-moderation/io.github.wivrn.wivrn/status

I'm not sure, if you requested a review and it was already done/dismissed and thus doesn't show anything anymore.

xytovl commented 1 month ago

status API returns

{
    "passes": false,
    "unrated": 0,
    "passed": 0,
    "not_passed": 0,
    "last_updated": "2024-09-27T11:58:48.582189",
    "review_requested_at": null
}

web page shows Capture d’écran du 2024-09-27 14-02-22

razzeee commented 1 month ago

seems correct, did you try to request a review again?

xytovl commented 1 month ago

Still get an error (request at 2024-09-27 13:31:49 UTC)

razzeee commented 1 month ago

okay, the app never has had a review and isn't listed in the search, as it does not have screenshots so both might cause this problem. I think we only allow reviews for "frontend apps" right now