search

flathub-infra / website

Monorepo with website and API
https://flathub.org
Apache License 2.0
232 stars 88 forks source link

Do not display screenshots with environment="windows" #4105

Closed CarlSchwan closed 2 weeks ago

CarlSchwan commented 2 weeks ago

For example: https://flathub.org/apps/org.kde.neochat the 2 last screenshots should not be displayed because they are marked as for Windows https://invent.kde.org/network/neochat/-/blob/master/org.kde.neochat.appdata.xml?ref_type=heads#L402

bbhtt commented 2 weeks ago

environment="windows" does not seem valid according to spec.

https://www.freedesktop.org/software/appstream/docs/chap-Metadata.html#tag-screenshots

Optionally, a screenshot may also have an environment property. This string property denotes the GUI environment the screenshot was recorded in, in the form of {env}:{style}, where {env} is a desktop-environment name in lowercase and {style} is a specific style that the desktop environment recognizes, e.g. light and dark for light and dark themes.

It's not in the form of env:style, and Windows is not a DE.

razzeee commented 2 weeks ago

But it's listed in https://github.com/ximion/appstream/blob/main/data/desktop-style-ids.txt

bbhtt commented 2 weeks ago

Yea it's weird, @ximion are env's supposed to strictly follow the format or not?

CarlSchwan commented 2 weeks ago

Also the spec is a bit wrong about env:style, for example only gnome and gnome:dark but not gnome:light are allowed because only values in the desktop-style-ids.txt are allowed.

bbhtt commented 2 weeks ago

Yea it's weird, @ximion are env's supposed to strictly follow the format or not?

Ah I guess this the exact same question as https://github.com/ximion/appstream/issues/667