search

flathub-infra / website

Monorepo with website and API
https://flathub.org
Apache License 2.0
232 stars 88 forks source link

utils: Ignore non-Linux screenshots #4106

Closed bbhtt closed 2 weeks ago

bbhtt commented 2 weeks ago

Fixes https://github.com/flathub-infra/website/issues/4105

bbhtt commented 2 weeks ago

greenlet does not build with python 3.13

razzeee commented 2 weeks ago

I would prefer to not have is_linux exposed in the end, as it doesn't seem of much value?

bbhtt commented 2 weeks ago

I would prefer to not have is_linux exposed in the end, as it doesn't seem of much value?

Hm maybe I can expose environment instead directly. Seems like it will me more useful than this.

razzeee commented 2 weeks ago

Should be good to go, optional things I can think of:

  1. Omit null, when not set (save data on api requests)
  2. Have a test, that consumes macos/windows screenshots and check, if they are removed
razzeee commented 2 weeks ago

Thank you