flathub / cc.arduino.IDE2

https://flathub.org/apps/details/cc.arduino.IDE2
6 stars 4 forks source link

Note: Enabling Native Wayland Support #19

Closed SuperNinja-4965 closed 1 year ago

SuperNinja-4965 commented 1 year ago

EDIT: For the full conversation on this topic please see PR #18.

To me as long as it is not the default in the platform it shouldn't be merged.

This makes sense. As the advice for electron apps on flathub's documentation is not to enable wayland. And with the sudden issue that @sebastian-de is experiencing with the app i think we should hold off on wayland support until electron better supports wayland natively (without enabling potentially experimental options) and the default recommended options for the electron platform are changed to enable wayland.

@sebastian-de i understand that xWayland is not perfect but after hearing what @hfiguiere said until those two requirements are met i agree with them on NOT merging this and if you truly want wayland native then you would be better patching this in yourself. I would consider making these changes to a beta branch but i believe that this may cause confusion with people thinking that the branch is for the nightly builds or an actual beta run of the IDE.

If things change in the future then we can look at this again but until then i'm going to close this pr and pin it for future reference.

If however you do want to use wayland you can enable it yourself by following the steps in the README

Originally posted by @joshuag1000 in https://github.com/flathub/cc.arduino.IDE2/issues/18#issuecomment-1263777116