Closed sebastian-de closed 1 year ago
Started test build 113316
Build 113316 successful To test this build, install it from the testing repository:
flatpak install --user https://dl.flathub.org/build-repo/110918/cc.arduino.IDE2.flatpakref
Following up the discussion from https://github.com/flathub/cc.arduino.IDE2/pull/18 With this commit, one can enable Wayland locally by running
flatpak override --user --socket=wayland cc.arduino.IDE2
flatpak override --user --env=ELECTRON_FLAGS="--enable-features=UseOzonePlatform --ozone-platform=wayland" cc.arduino.IDE2
without the need to patch arduino-ide.sh
.
Following up the discussion from #18 With this commit, one can enable Wayland locally by running
flatpak override --user --socket=wayland cc.arduino.IDE2 flatpak override --user --env=ELECTRON_FLAGS="--enable-features=UseOzonePlatform --ozone-platform=wayland" cc.arduino.IDE2
without the need to patch
arduino-ide.sh
.
I initially didnt see the point in making this change but i can now see what you are trying to do here. im hesitant to rename any variable to have the word electron in them incase they get used be electron somewhere down the line (especially with such a generic name). Im going to rename your variable a little and since you decided to clear the whitespace lets use proper english and put a : there instead.
Started test build 113340
I have renamed ELECTRON_FLAGS to CUSTOM_IDE_FLAGS as this could be used for other flags for the ide too in theory and it keeps the variable's purpose obvious.
I have renamed ELECTRON_FLAGS to CUSTOM_IDE_FLAGS as this could be used for other flags for the ide too in theory and it keeps the variable's purpose obvious.
Sure, I just didn't want to keep the too generic FLAGS.
I have renamed ELECTRON_FLAGS to CUSTOM_IDE_FLAGS as this could be used for other flags for the ide too in theory and it keeps the variable's purpose obvious.
Sure, I just didn't want to keep the too generic FLAGS.
that's fine and makes sense if we are going to enable support for flatpak override to be used like this. I have also tidied up the readme a little. Once the test build is done and i have tested to make sure all is good I will merge this as i cant see a reason why not.
Build 113340 was cancelled
bot, build
Queued test build for cc.arduino.IDE2.
Started test build 113355
Build 113355 successful To test this build, install it from the testing repository:
flatpak install --user https://dl.flathub.org/build-repo/110957/cc.arduino.IDE2.flatpakref
That way
$ELECTRON_FLAGS
can be passed to the IDE. Corresponding README section added.(Also removes one trailing whitespace in README.md).