search

flathub / cc.arduino.arduinoide

https://flathub.org/apps/details/cc.arduino.arduinoide
4 stars 8 forks source link

Add adafruit-nrfutil to ide to allow working with Adafruit_nRF52 boards. #46

Closed SuperNinja-4965 closed 1 year ago

SuperNinja-4965 commented 1 year ago

Closes #36. Includes the binary into the flatpak that is required to use Adafruit_nRF52 boards with the IDE. Once the board has been installed into the ide through the board manager the IDE will work with these boards now.

flathubbot commented 1 year ago

Started test build 49872

flathubbot commented 1 year ago

Build 49872 successful To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/32483/cc.arduino.arduinoide.flatpakref
A6GibKm commented 1 year ago

Hello, did you test that this works as expected?

SuperNinja-4965 commented 1 year ago

Hello, did you test that this works as expected?

I have yes.

To use the Adafruit boards all that is required is to add https://adafruit.github.io/arduino-board-index/package_adafruit_index.json as an additional board and then install Adafruit nRF52 by Adafruit in the boards manager meaning that the step of installing the tool by pip (pip3 install --user adafruit-nrfutil) is not required by flatpak users.

Without this binary included the IDE will fail verifying or uploading with the error on these boards: 

exec: "adafruit-nrfutil": executable file not found in $PATH
Error compiling for board Adafruit Feather nRF52832.

Hence closing #36

A6GibKm commented 1 year ago

Thanks! Just to be clear, the experience installing the nRF52 is identically to the one with arduino installed directly on the host with this patch? Or it could use a note in the readme?

SuperNinja-4965 commented 1 year ago

Thanks! Just to be clear, the experience installing the nRF52 is identically to the one with arduino installed directly on the host with this patch? Or it could use a note in the readme?

The installation steps are identical except the step of installing the pip package that provides the adafruit-nrfutil is entirely optional (step 2 linked here: https://learn.adafruit.com/bluefruit-nrf52-feather-learning-guide/arduino-bsp-setup#2-linux-only-adafruit-nrfutil-tool-installation-2860591). The only effect installing the pip package would have on the system would make the binary available outside of flatpak. This pr effectively makes the board installation process identical to the installation process on Windows and MacOS.