flathub / ch.protonmail.protonmail-bridge

https://flathub.org/apps/details/ch.protonmail.protonmail-bridge
11 stars 7 forks source link

Enable the Wayland socket by default #115

Closed RayJW closed 12 months ago

RayJW commented 1 year ago

This PR enables the Wayland socket and sets x11 as fallback. I think there isn't really a reason for not doing it. I checked on a device running Wayland and a device running x11 and both work fine with this config with the upside of proper fractional scaling and the many other advantages of using native Wayland.

A6GibKm commented 1 year ago

There were issues in the past, I will test it on top of the runtime update, maybe it improved on recent versions.

zestygrass commented 1 year ago

I'm using the bridge on wayland for last week or so, haven't had any issues with it's functionality.

RayJW commented 1 year ago

I have also been using it for months now and never had any issue. However, I don't use all the functionality, but I don't see a reason why something like multi-account would break from Wayland if everything else is working perfectly fine.

flathubbot commented 1 year ago

Started test build 65477

flathubbot commented 1 year ago

Build 65477 successful To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/48115/ch.protonmail.protonmail-bridge.flatpakref
A6GibKm commented 1 year ago

I tested it and besides having weird window decorations it works fine. Probably because of https://www.fedoraproject.org/wiki/Releases/39/ChangeSet#No_custom_Qt_theming_for_Fedora_Workstation.

RayJW commented 1 year ago

I noticed that too, but that's expected since Gnome went with the weird decision to not support server side window decorations on Wayland. So those are the Proton Bridge client side decorations.

A6GibKm commented 1 year ago

My only hesitation to not merge this just now is not having an idea if upstreams considers the app to be Wayland ready.

RayJW commented 1 year ago

I just checked the repo and they fixed multiple issues people had with Wayland without ever saying anything about switching to XWayland. So, I think it is considered officially supported, although I couldn't find a reference to that directly anywhere yet.

flathubbot commented 1 year ago

Started test build 65519

flathubbot commented 1 year ago

Build 65519 successful To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/48159/ch.protonmail.protonmail-bridge.flatpakref
A6GibKm commented 12 months ago

Thanks!