Fix StartupWMClass for Delta Chat desktop file

[fat0troll]

The actual WM_CLASS property of Delta Chat window is deltachat, not delta.

[flathubbot]

Started test build 82678

[flathubbot]

Build 82678 failed

[muelli]

no idea why it would fail with your modification:

[?25hnpm verb stack Error: command failed
npm verb stack     at ChildProcess.<anonymous> (/usr/lib/sdk/node18/lib/node_modules/npm/node_modules/@npmcli/promise-spawn/lib/index.js:53:27)
npm verb stack     at ChildProcess.emit (node:events:517:28)
npm verb stack     at maybeClose (node:internal/child_process:1098:16)
npm verb stack     at ChildProcess._handle.onexit (node:internal/child_process:303:5)
npm verb pkgid deltachat-node@1.121.0
npm verb cwd /run/build/delta/main
npm verb Linux 5.15.0-47-generic
npm verb node v18.18.1
npm verb npm  v9.8.1
npm ERR! code 1
npm ERR! path /run/build/delta/main/node_modules/deltachat-node
npm ERR! command failed
npm ERR! command sh -c node node/scripts/install.js
npm ERR! [i] USE_SYSTEM_LIBDELTACHAT is true, rebuilding c bindings and using pkg-config to retrieve lib paths and cflags of libdeltachat
npm ERR! [i] running `npm run build:bindings:c:c`
npm ERR! 
npm ERR! > deltachat-node@1.121.0 build:bindings:c:c
npm ERR! > cd node && node-gyp rebuild
npm ERR! npm info using npm@9.8.1
npm ERR! npm info using node@v18.18.1
npm ERR! gyp info it worked if it ends with ok
npm ERR! gyp verb cli [
npm ERR! gyp verb cli   '/usr/lib/sdk/node18/bin/node',
npm ERR! gyp verb cli   '/usr/lib/sdk/node18/lib/node_modules/npm/node_modules/node-gyp/bin/node-gyp.js',
npm ERR! gyp verb cli   'rebuild'
npm ERR! gyp verb cli ]
npm ERR! gyp info using node-gyp@9.4.0
npm ERR! gyp info using node@18.18.1 | linux | x64
npm ERR! gyp verb command rebuild []
npm ERR! gyp verb command clean []
npm ERR! gyp verb clean removing "build" directory
npm ERR! gyp verb command configure []
npm ERR! gyp verb find Python Python is not set from command line or npm configuration
npm ERR! gyp verb find Python Python is not set from environment variable PYTHON
npm ERR! gyp verb find Python checking if "python3" can be used
npm ERR! gyp verb find Python - executing "python3" to get executable path
npm ERR! gyp verb find Python - executable path is "/usr/bin/python3"
npm ERR! gyp verb find Python - executing "/usr/bin/python3" to get version
npm ERR! gyp verb find Python - version is "3.11.5"
npm ERR! gyp info find Python using Python version 3.11.5 found at "/usr/bin/python3"
npm ERR! gyp verb get node dir no --target version specified, falling back to host node version: 18.18.1
npm ERR! gyp verb command install [ '18.18.1' ]
npm ERR! gyp verb install input version string "18.18.1"
npm ERR! gyp verb install installing version: 18.18.1
npm ERR! gyp verb install --ensure was passed, so won't reinstall if already installed
npm ERR! gyp verb install version is already installed, need to check "installVersion"
npm ERR! gyp verb got "installVersion" 9
npm ERR! gyp verb needs "installVersion" 11
npm ERR! gyp verb install version is no good; reinstalling
npm ERR! gyp verb ensuring devDir is created /run/build/delta/flatpak-node/cache/node-gyp/18.18.1
npm ERR! gyp http GET https://nodejs.org/download/release/v18.18.1/node-v18.18.1-headers.tar.gz
npm ERR! 2023-11-20T17:35:04.954Z agentkeepalive sock[0#nodejs.org:443::::::::true:::::::::::::] create, timeout undefinedms
npm ERR! 2023-11-20T17:35:04.959Z agentkeepalive sock[0#nodejs.org:443::::::::true:::::::::::::](requests: 1, finished: 0) error: Error: getaddrinfo EAI_AGAIN nodejs.org
npm ERR!     at GetAddrInfoReqWrap.onlookup [as oncomplete] (node:dns:108:26) {
npm ERR!   errno: -3001,
npm ERR!   code: 'EAI_AGAIN',
npm ERR!   syscall: 'getaddrinfo',
npm ERR!   hostname: 'nodejs.org'
npm ERR! }, listenerCount: 2
npm ERR! gyp WARN install got an error, rolling back install
npm ERR! gyp verb command remove [ '18.18.1' ]
npm ERR! gyp verb remove using node-gyp dir: /run/build/delta/flatpak-node/cache/node-gyp
npm ERR! gyp verb remove removing target version: 18.18.1
npm ERR! gyp verb remove removing development files for version: 18.18.1
npm ERR! 2023-11-20T17:35:04.961Z agentkeepalive sock[0#nodejs.org:443::::::::true:::::::::::::](requests: 1, finished: 0) close, isError: true
npm ERR! gyp ERR! configure error 
npm ERR! gyp ERR! stack FetchError: request to https://nodejs.org/download/release/v18.18.1/node-v18.18.1-headers.tar.gz failed, reason: getaddrinfo EAI_AGAIN nodejs.org
npm ERR! gyp ERR! stack     at ClientRequest.<anonymous> (/usr/lib/sdk/node18/lib/node_modules/npm/node_modules/minipass-fetch/lib/index.js:130:14)
npm ERR! gyp ERR! stack     at ClientRequest.emit (node:events:517:28)
npm ERR! gyp ERR! stack     at TLSSocket.socketErrorListener (node:_http_client:501:9)
npm ERR! gyp ERR! stack     at TLSSocket.emit (node:events:529:35)
npm ERR! gyp ERR! stack     at emitErrorNT (node:internal/streams/destroy:151:8)
npm ERR! gyp ERR! stack     at emitErrorCloseNT (node:internal/streams/destroy:116:3)
npm ERR! gyp ERR! stack     at process.processTicksAndRejections (node:internal/process/task_queues:82:21)
npm ERR! gyp ERR! System Linux 5.15.0-47-generic
npm ERR! gyp ERR! command "/usr/lib/sdk/node18/bin/node" "/usr/lib/sdk/node18/lib/node_modules/npm/node_modules/node-gyp/bin/node-gyp.js" "rebuild"
npm ERR! gyp ERR! cwd /run/build/delta/main/node_modules/deltachat-node/node
npm ERR! gyp ERR! node -v v18.18.1
npm ERR! gyp ERR! node-gyp -v v9.4.0
npm ERR! gyp ERR! not ok 
npm ERR! node:child_process:965
npm ERR!     throw err;
npm ERR!     ^
npm ERR! 
npm ERR! Error: Command failed: npm run build:bindings:c:c
npm ERR!     at checkExecSyncError (node:child_process:890:11)
npm ERR!     at execSync (node:child_process:962:15)
npm ERR!     at run (/run/build/delta/main/node_modules/deltachat-node/node/scripts/install.js:7:3)
npm ERR!     at Object.<anonymous> (/run/build/delta/main/node_modules/deltachat-node/node/scripts/install.js:13:3)
npm ERR!     at Module._compile (node:internal/modules/cjs/loader:1256:14)
npm ERR!     at Module._extensions..js (node:internal/modules/cjs/loader:1310:10)
npm ERR!     at Module.load (node:internal/modules/cjs/loader:1119:32)
npm ERR!     at Module._load (node:internal/modules/cjs/loader:960:12)
npm ERR!     at Function.executeUserEntryPoint [as runMain] (node:internal/modules/run_main:86:12) {
npm ERR!   status: 1,
npm ERR!   signal: null,
npm ERR!   output: [ null, null, null ],
npm ERR!   pid: 20,
npm ERR!   stdout: null,
npm ERR!   stderr: null
npm ERR! }
npm ERR! 
npm ERR! Node.js v18.18.1

[fat0troll]

it fails since this commit: https://github.com/flathub/chat.delta.desktop/commit/aaa0a834ed230329e4f445d211ed3e3f0463a0ce

[Simon-Laux]

ok failing ci looks unreleated let's merge this pr and fix the ci in a dedicated pr (I'm anyways in the process of updating the flatpack to dc-desktop 1.42.1)

Edit: looks like merging it impossible until ci is fixed, so seems like merging needs to wait.

[flathubbot]

Started test build 83532

[flathubbot]

Build 83532 failed