search

flathub / chat.delta.desktop

https://flathub.org/apps/details/chat.delta.desktop
12 stars 7 forks source link

update to 1.44 #125

Closed Simon-Laux closed 7 months ago

Simon-Laux commented 7 months ago

Observations:

Update: I solved both observations/issues

TODO

closes https://github.com/flathub/chat.delta.desktop/issues/118 closes https://github.com/deltachat/deltachat-desktop/issues/2800

flathubbot commented 7 months ago

Started test build 102538

flathubbot commented 7 months ago

Started test build 102540

flathubbot commented 7 months ago

Build 102538 failed

flathubbot commented 7 months ago

Build 102540 successful To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/85320/chat.delta.desktop.flatpakref
flathubbot commented 7 months ago

Started test build 104132

flathubbot commented 7 months ago

Started test build 104133

flathubbot commented 7 months ago

Build 104132 successful To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/86922/chat.delta.desktop.flatpakref
flathubbot commented 7 months ago

Build 104133 successful To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/86923/chat.delta.desktop.flatpakref
flathubbot commented 7 months ago

Started test build 105052

flathubbot commented 7 months ago

Build 105052 failed

flathubbot commented 7 months ago

Started test build 105069

flathubbot commented 7 months ago

Build 105069 successful To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/87874/chat.delta.desktop.flatpakref
flathubbot commented 7 months ago

Started test build 105085

flathubbot commented 7 months ago

Build 105085 successful To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/87890/chat.delta.desktop.flatpakref
muelli commented 7 months ago

I mildly object the removal of DRI access, because device=all is an accident rather than a deliberate choice.

I wonder how self-explanatory ELECTRON_OZONE_PLATFORM_HINT is. Neither the code nor the commit reveals why it's necessary so it could be difficult to assess when it's appropriate to remove it in the future.

But I don't block on those for merging, so feel free to merge.

Mikaela commented 7 months ago

I mildly object the removal of DRI access, because device=all is an accident rather than a deliberate choice.

The flathub validator bot rejects other device rules coexisting with device=all, so the alternative would be removing device=all and breaking qr code scanning in device linking.

I wonder how self-explanatory ELECTRON_OZONE_PLATFORM_HINT is. Neither the code nor the commit reveals why it's necessary so it could be difficult to assess when it's appropriate to remove it in the future.

I guess a comment linking to electron environment variables documentation and saying the app won't launch under wayland otherwise would be trivial to add.

flathubbot commented 7 months ago

Started test build 105192

flathubbot commented 7 months ago

Started test build 105193

Simon-Laux commented 7 months ago

I mildly object the removal of DRI access, because device=all is an accident rather than a deliberate choice

It is unfortunate that there seems not to be a more specific way to access webcams, like a device=webcams/cameras or a portal that is so mature that it was added to Electron.

flathubbot commented 7 months ago

Build 105192 successful To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/87998/chat.delta.desktop.flatpakref
flathubbot commented 7 months ago

Build 105193 failed

flathubbot commented 7 months ago

Started test build 105196

flathubbot commented 7 months ago

Build 105196 was cancelled

flathubbot commented 7 months ago

Started test build 105197

flathubbot commented 7 months ago

Build 105197 successful To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/88003/chat.delta.desktop.flatpakref