update to 1.44

[Simon-Laux]

Observations:

• 124 works (it is already merged into this pr), but has blurriness issues with systemwide display scaling in gnome.

• notification closing still crashes the app (clicking on notifications or entering a chat that has open notifications)

Update: I solved both observations/issues

TODO

• [x] optionally: investigate the blurriness - but that seems to be an upstream chromium bug (https://github.com/flathub/chat.delta.desktop/pull/124#issuecomment-1962575127)
• [x] fix notification crash (https://github.com/deltachat/deltachat-desktop/issues/3590)
• [x] wait for 1.44 release, currently it is based on the 1.43.x test releases

closes https://github.com/flathub/chat.delta.desktop/issues/118 closes https://github.com/deltachat/deltachat-desktop/issues/2800

[flathubbot]

Started test build 102538

[flathubbot]

Started test build 102540

[flathubbot]

Build 102538 failed

[flathubbot]

Build 102540 successful To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/85320/chat.delta.desktop.flatpakref

[flathubbot]

Started test build 104132

[flathubbot]

Started test build 104133

[flathubbot]

Build 104132 successful To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/86922/chat.delta.desktop.flatpakref

[flathubbot]

Build 104133 successful To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/86923/chat.delta.desktop.flatpakref

[flathubbot]

Started test build 105052

[flathubbot]

Build 105052 failed

[flathubbot]

Started test build 105069

[flathubbot]

Build 105069 successful To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/87874/chat.delta.desktop.flatpakref

[flathubbot]

Started test build 105085

[flathubbot]

Build 105085 successful To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/87890/chat.delta.desktop.flatpakref

[muelli]

I mildly object the removal of DRI access, because device=all is an accident rather than a deliberate choice.

I wonder how self-explanatory ELECTRON_OZONE_PLATFORM_HINT is. Neither the code nor the commit reveals why it's necessary so it could be difficult to assess when it's appropriate to remove it in the future.

But I don't block on those for merging, so feel free to merge.

[Mikaela]

I mildly object the removal of DRI access, because device=all is an accident rather than a deliberate choice.

The flathub validator bot rejects other device rules coexisting with device=all, so the alternative would be removing device=all and breaking qr code scanning in device linking.

I wonder how self-explanatory ELECTRON_OZONE_PLATFORM_HINT is. Neither the code nor the commit reveals why it's necessary so it could be difficult to assess when it's appropriate to remove it in the future.

I guess a comment linking to electron environment variables documentation and saying the app won't launch under wayland otherwise would be trivial to add.

[flathubbot]

Started test build 105192

[flathubbot]

Started test build 105193

[Simon-Laux]

I mildly object the removal of DRI access, because device=all is an accident rather than a deliberate choice

It is unfortunate that there seems not to be a more specific way to access webcams, like a device=webcams/cameras or a portal that is so mature that it was added to Electron.

[flathubbot]

Build 105192 successful To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/87998/chat.delta.desktop.flatpakref

[flathubbot]

Build 105193 failed

[flathubbot]

Started test build 105196

[flathubbot]

Build 105196 was cancelled

[flathubbot]

Started test build 105197

[flathubbot]

Build 105197 successful To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/88003/chat.delta.desktop.flatpakref