Update to 1.2.0 - Githubissues

flathubbot commented 2 years ago

Started test build 86171

flathubbot commented 2 years ago

Build 86171 failed

hfiguiere commented 2 years ago

seems that it is missing some crates.

A6GibKm commented 2 years ago

Hello, any update to this? I think it is the only app listed in Apps for GNOME using 40.

Kekun commented 1 year ago

bot build

Kekun commented 1 year ago

Please bot, could you build this? (I forgot basic politeness)

flathubbot commented 1 year ago

Started test build 101516

flathubbot commented 1 year ago

Build 101516 failed

hfiguiere commented 1 year ago

on PR, it starts automatically. And if it says "Queued" then the bot is on it. There was some lag today.

And for the politiness, the bot wants a ,.

hfiguiere commented 1 year ago

build fail because it want to checkout something at build time.

A6GibKm commented 1 year ago

I sent this MR to metronome, ran meson-dist on Builder and I was able to produce a tarball which builds just fine with flatpak-builder.

I also suggest the following changes

modified   com.adrienplazas.Metronome.json
@@ -9,15 +9,13 @@
     "command": "metronome",
     "finish-args" : [
         "--device=dri",
+        "--share=ipc",
         "--socket=fallback-x11",
         "--socket=pulseaudio",
         "--socket=wayland"
     ],
     "build-options" : {
-        "append-path" : "/usr/lib/sdk/rust-stable/bin",
-        "env" : {
-            "CARGO_HOME" : "/run/build/metronome/cargo"
-        }
+        "append-path" : "/usr/lib/sdk/rust-stable/bin"
     },
     "cleanup" : [
         "/include",

as apps running on x11 see benefits somehow from ipc and the CARGO_HOME variable is not needed, at least once my MR is in, I cannot say if it was ever needed though.

@bilelmoussaoui I think the problem was specifically fixed after setting both gtk-rs and libadwaita-rs to their last stable release in crates.io instead of git, do you have an idea of what might had caused the issue in the first place? We have certainly shipped stuff before using git.

bilelmoussaoui commented 1 year ago

@bilelmoussaoui I think the problem was specifically fixed after setting both gtk-rs and libadwaita-rs to their last stable release in crates.io instead of git, do you have an idea of what might had caused the issue in the place? We have certainly shipped stuff before using git.

I think that issue was fixed already on gtk-rs side.