search

flathub / com.albiononline.AlbionOnline

https://flathub.org/apps/details/com.albiononline.AlbionOnline
GNU General Public License v3.0
9 stars 7 forks source link

Icons appdata #16

Closed nedrichards closed 6 years ago

nedrichards commented 6 years ago

this should address #3 and goes towards https://github.com/flathub/flathub.org/issues/16

@valentindavid please feel free to modify the OARS ratings from https://hughsie.github.io/oars/generate.html as I think you're a bigger player of the game than I am.

Note: flathub policy on icons has changed. we're OK with using official icons strictly for the purpose of truly and accurately describing the app

nedrichards commented 6 years ago

bot, build

AsciiWolf commented 6 years ago

It looks like that Albion Online still has the icon missing and still cannot be found in GNOME Software.

edit: It looks like that the screenshot links are wrong:

com.albiononline.AlbionOnline.appdata.xml: FAILED:
• url-not-found         : <screenshot> url not found [https://lh6.googleusercontent.com/4aflLjV-uNxYFDi8nd4aRQO3yTM1n5IucDEu2HCEPIWXGQOOfJf5yNyq6fPk4piyN8eWvMC29ncIko8]
• url-not-found         : <screenshot> url not found [https://lh3.googleusercontent.com/Hqy_rvy99OHvlTjuX2-_cVH6_PXvYCZ_-PDGgv-EzsEXKj74Boj95LVp9xe08RLyT3U8p7dpduiIfuA]
• url-not-found         : <screenshot> url not found [https://lh5.googleusercontent.com/4MJbbpPlNMSJ6fklynVgDzQLN7bfx4sGHDBuxr-Nt8KaBpVhipeUSM23nRw-TugjzfDGLtknNs2D4tI]
Validation of files failed
nedrichards commented 6 years ago

Agreed. This is moderately irritating now.

On Fri, 26 Jan 2018, 15:42 AsciiWolf, notifications@github.com wrote:

It looks like that Albion Online still has the icon missing and still cannot be found in GNOME Software.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/flathub/com.albiononline.AlbionOnline/pull/16#issuecomment-360819469, or mute the thread https://github.com/notifications/unsubscribe-auth/AASeVZ-yZcdbA7RQXkBzTangS_K_pm6Yks5tOfJZgaJpZM4Rs-lt .

AsciiWolf commented 6 years ago

It looks like that the icons are completely missing in Flathub repo.

nedrichards commented 6 years ago

I believe fixed by https://github.com/flathub/com.albiononline.AlbionOnline/commit/0d572015ab425de496612a53caf70ce3cb8b24d8 (and the fixup commit after)

AsciiWolf commented 6 years ago

@nedrichards Yep, I can confirm that it is fixed. Thanks!