flathub / com.albiononline.AlbionOnline

https://flathub.org/apps/details/com.albiononline.AlbionOnline
GNU General Public License v3.0
8 stars 7 forks source link

Albion Online cannot be found in GNOME Software #3

Closed AsciiWolf closed 6 years ago

AsciiWolf commented 7 years ago

I have flathub repo added, searching for Albion Online in GNOME Software returns no results.

AsciiWolf commented 7 years ago

gnome-software_albion

[asciiwolf@desktop ~]$ flatpak remote-ls --user flathub|grep Albion
com.albiononline.AlbionOnline
TingPing commented 7 years ago

By default I believe gnome-software hides proprietary apps, you can toggle that in dconf-editor.

AsciiWolf commented 7 years ago

@TingPing I don't think that's the case. I can see Steam and other proprietary apps without any problem.

valentindavid commented 7 years ago

Because it is installed. Uninstall Steam and fully restart gnome-software. There is a background process to kill to fully restart. Then search for Steam.

I have tried with Spotify. It cannot be listed if not installed.

valentindavid commented 7 years ago

However after, enabling "/org/gnome/software/show-non-free-software", I still do not see non install proprietary apps.

valentindavid commented 7 years ago

Actually Steam shows up. However Albion Online, Discord and Spotify do not.

valentindavid commented 7 years ago

GeoGebra also shows up. The main difference I see in the appstream is the presence or not of icon.

valentindavid commented 7 years ago

It is on purpose that GNOME Software does not show applications without icon. We do not have any icon for Albion Online on the appstream, because the icon is in the "extra" data downloaded from Albion Online's server at installation. I am not sure what would be the legality of hosting the icon file directly in Flathub.

TingPing commented 7 years ago

Ah, if they don't allow redistribution of their icons then I don't think we should. Maybe @hughsie knows of an alternative?

hughsie commented 7 years ago

You can have a 'remote' icon in the appdata file that is downloaded in the client. Thus us how we do Webapp like Twitter where the icon can't be shipped.

valentindavid commented 7 years ago

Thanks for the info.

I am not sure however that flatpak can generate remote icons in the appstream. I cannot give it in the appdata, icons are not allowed there.

hughsie commented 7 years ago

Is it a fatal validation error? I've never tried using a remote icon for a desktop app, normally the icon is redistributable.

valentindavid commented 7 years ago

"appstream-util validate-relax" refuses it.

According to the specification it is for appstream collection. Not for upstream metadata (appdata).

hughsie commented 7 years ago

Sure, but (as the author of appstream-util) sometimes we need to be pragmatic.

valentindavid commented 7 years ago

I think flatpak calls "appstream-compose" on the result of the build.

In my case I have an appdata XML file. But no desktop file yet, nor icons.

If this command is fixed, maybe it would work for me.

AsciiWolf commented 7 years ago

What about using some generic placeholder icon for the AppStream metadata?

valentindavid commented 7 years ago

You mean using a generic icon in a temporary .desktop file? The appstream icon comes from the .desktop file, not the metadata.

AsciiWolf commented 7 years ago

@valentindavid

You mean using a generic icon in a temporary .desktop file?

Yes.

andrewschott commented 7 years ago

Has anyone asked them? I have found a pleasant question regarding limited permission to do things goes a long way.

Just asking.

AsciiWolf commented 6 years ago

Sandbox Interactive employee told me that it is probably okay to use an icon from the Albion Online press kit, but he was not 100% sure.

TingPing commented 6 years ago

Press kit is a good start, but I don't see any actual legal documents over theirs?

AsciiWolf commented 6 years ago

I wrote to the company's CEO about this but did not get any reply yet.

TingPing commented 6 years ago

The remote image issue was fixed recently: https://github.com/hughsie/appstream-glib/commit/74ebf5192296f0ef26f6c51ee5f103d9fd72a3df

So once that is released and lands on the builders we can use remote images.

AsciiWolf commented 6 years ago

Great!

AsciiWolf commented 6 years ago

@TingPing Any news regarding the remote images?

TingPing commented 6 years ago

Yes it is supported now, see the other proprietary apps like Skype, Discord, etc for examples.

AsciiWolf commented 6 years ago

Why is it not supported yet in Albion Online?

valentindavid commented 6 years ago

Do you have an URL to an icon?

AsciiWolf commented 6 years ago

What about this one?

AsciiWolf commented 6 years ago

Although I see that the icon is probably in a bad resolution.

hughsie commented 6 years ago

64x64 is the minimum size icon that it will use. R

nedrichards commented 6 years ago

This is also required to use icons on the upcoming apps page (still in beta). However, we can now host these icons if we wish - you don't have to use a remote icon if you don't want to.

AsciiWolf commented 6 years ago

This issue was fixed in #16.