search

flathub / com.axosoft.GitKraken

https://flathub.org/apps/details/com.axosoft.GitKraken
8 stars 9 forks source link

Icon shows twice in dock #80

Open jhaygood86 opened 4 years ago

jhaygood86 commented 4 years ago

Fedora Workstation 32, using latest Flathub package, on GNOME 3.36

image

One is active, the other is not. Clicking on the non-active one spawns the active one

Lctrs commented 4 years ago

I've noticed that too. Will ask upstream about this.

jhaygood86 commented 4 years ago

This is pretty recent behavior. It was working fine some weeks ago.

llabusch93 commented 4 years ago

Any news on this one?

Lctrs commented 4 years ago

Still haven't had the time to look at it. Upstream said that's none of their business since they don't support flatpak and I haven't tested with upstream RPM.

ghost commented 3 years ago

Got this happening to me too and finally decided to do something about it. Reported as feedback to Axosoft and got this:

I am not seeing this behavior on Ubuntu 20.04. However, I have heard of this behavior with non-LTS versions of Ubuntu (i.e. Ubuntu 20.10). As a note, GitKraken only supports LTS versions of Ubuntu.

Still working with Axosoft to figure it out, but sounds like it's not a Flatpak package issue.

ghost commented 3 years ago

Ok, did some sleuthing and ended up finding the problem. There's a second .desktop file with the same StartupWMClass as the main file so Gnome is getting confused. Quick fix is to just delete the gitkraken-url-handler.desktop file.

I've given this feedback to Axosoft so hopefully it will be fixed upstream soon enough.

llabusch93 commented 3 years ago

Hey @JamieCarlAPIR

for me it does not work....

I deleted the URL handler files in the following location and restarted Gnome, but no luck...

/home/llabusch/.local/share/flatpak/app/com.axosoft.GitKraken/current/active/files/share/applications

Lctrs commented 3 years ago

Thanks for your investigation @JamieCarlAPIR !

I would rather keep the second desktop file installed than removing it as this issue is very minor to me. Will wait for either Axosoft or Gnome to fix this.

ghost commented 3 years ago

Thanks for your investigation @JamieCarlAPIR !

I would rather keep the second desktop file installed than removing it as this issue is very minor to me. Will wait for either Axosoft or Gnome to fix this.

Commenting out StartupWMClass in the second desktop file is also another option.

Obviously, both of these solutions will be overridden on an update.

Just heard back from Axosoft again. It's been "forwarded to their dev team". I was also told, again for like the 3rd time, "we do not support non-LTS versions of Ubuntu - so there may be some unexpected behavior there".

Lctrs commented 3 years ago

Commenting out StartupWMClass in the second desktop file is also another option.

Obviously, both of these solutions will be overridden on an update.

We could do that at build time here : https://github.com/flathub/com.axosoft.GitKraken/blob/master/gitkraken-build.sh#L23, but I'm worried if we would hit #30 again if the opening is handled by the second desktop file.

Either way, we'll have a problem. This one is more proeminent, so I guess it'll have the priority.

Just heard back from Axosoft again. It's been "forwarded to their dev team". I was also told, again for like the 3rd time, "we do not support non-LTS versions of Ubuntu - so there may be some unexpected behavior there".

Well, they also provide .rpm, so they support Fedora as well. You can tell them other users reported the issue on this OS.

ghost commented 3 years ago

Well, they also provide .rpm, so they support Fedora as well. You can tell them other users reported the issue on this OS.

Just to be "that guy", I spun up a VM and installed Ubuntu 20.04.02-LTS, did a "dist-upgrade" and then installed GitKraken from the latest .deb on their website and guess what........it's broken too.

Lctrs commented 3 years ago

Stop fighting kids.

ghost commented 3 years ago

Hey @JamieCarlAPIR

for me it does not work....

I deleted the URL handler files in the following location and restarted Gnome, but no luck...

/home/llabusch/.local/share/flatpak/app/com.axosoft.GitKraken/current/active/files/share/applications

So I just had to do a crash course in how Flatpack handles .desktop files. (This has a good explanation: https://github.com/flatpak/flatpak/issues/1286). So given that, you need to edit/remove the file in /home/llabusch/.local/share/flatpak/exports/share/applications for it to work.

I managed to replicate your issue and once I updated the file above, it worked for me.

UnstoppableMango commented 1 year ago

This has a good explanation: https://github.com/flatpak/flatpak/issues/1286

This was very helpful, what I ended up doing was copying both .desktop files to ~/.local/share/applications since it has priority and in the UrlHandler file I commented out the StartupWMClass= entry. I also changed the Exec= to the full path of ~/.local/share/flatpak/exports/bin/com.axosoft.GitKraken (I have no idea how paths are resolved but the gitkraken binary is not in my path).

The goal being that I don't have to repeat any steps after updating. The originals in ~/.local/share/flatpak are unmodified.

Would be nice if this just worked out of the box though, not sure what needs to change to make that happen since this seems to be a relatively old issue.