flathub / com.calibre_ebook.calibre

https://flathub.org/apps/details/com.calibre_ebook.calibre
13 stars 13 forks source link

Freedesktop SDK 24.08 will be dropping appstream-util #209

Closed bbhtt closed 6 months ago

bbhtt commented 6 months ago

The manifest uses appstream-util modify. Please try to convert it to patch

ghisvail commented 6 months ago

A little bit more context and explanation would come a long way here

bbhtt commented 6 months ago

A little bit more context and explanation would come a long way here

You should drop these two lines and convert it to rename-appdata-file, rename-desktop-file see https://docs.flatpak.org/en/latest/flatpak-builder-command-reference.html

Patch won't work here since it is generated during build

https://github.com/flathub/com.calibre_ebook.calibre/blob/2d13713f74bf0b95af188ba8762a05a2f31a4607/com.calibre_ebook.calibre.yaml#L73-L76

ghisvail commented 6 months ago

So I am guessing it would become:

rename-appdata-file: calibre-gui.metainfo.xml

      # post-install for metainfo
      #- cp $FLATPAK_DEST/share/metainfo/{calibre-gui,$FLATPAK_ID}.metainfo.xml
      #- appstream-util modify $FLATPAK_DEST/share/metainfo/$FLATPAK_ID.metainfo.xml
      #  id $FLATPAK_ID
      #- appstream-util modify $FLATPAK_DEST/share/metainfo/$FLATPAK_ID.metainfo.xml
      #  launchable $FLATPAK_ID.desktop

am I correct?

bbhtt commented 6 months ago

You need rename-desktop-file too, to update the launchable.

ghisvail commented 6 months ago

Thanks for the pointers