flathub / com.discordapp.Discord

https://flathub.org/apps/details/com.discordapp.Discord
118 stars 43 forks source link

Gif picker keeps flashing #282

Open xmo-odoo opened 1 year ago

xmo-odoo commented 1 year ago

I'm lucky not to have photosensitive epilepsy, but I'd assume a victim of such would have a hard time (warning: flashes):

https://user-images.githubusercontent.com/7571158/230324718-7097b44c-8869-4c6c-94cf-735e92a50363.mp4

This is with:

TingPing commented 1 year ago

Probably report it to Discord: https://support.discord.com/hc/en-us/articles/360046057772-Discord-Bugs

xmo-odoo commented 1 year ago

Done, should I close this or leave it open in case other people stumble on it?

TingPing commented 1 year ago

Can leave it for now. I imagine it will get fixed next Electron update for them.

Bikutoso commented 1 year ago

I will add some additional information i found.

For one it's not only the gif picker that does it, it seems that after the gif picket glitches out switching servers and possibly unminimizing discord also causes flashing too for a while. And my .xsession-errors gets the message ERROR:shared_image_manager.cc(202)] SharedImageManager::ProduceSkia: Trying to Produce a Skia representation from a non-existent mailbox. every time it happens.

TingPing commented 1 year ago

@Bikutoso Can you test flatpak run --command=zypak-wrapper com.discordapp.Discord /app/discord/Discord --enable-gpu-rasterization --enable-zero-copy --enable-gpu-compositing --enable-native-gpu-memory-buffers --enable-oop-rasterization

And try removing/readding arguments to see if one is problematic?

Bikutoso commented 1 year ago

@Bikutoso Can you test flatpak run --command=zypak-wrapper com.discordapp.Discord /app/discord/Discord --enable-gpu-rasterization --enable-zero-copy --enable-gpu-compositing --enable-native-gpu-memory-buffers --enable-oop-rasterization

And try removing/readding arguments to see if one is problematic?

All combinations of the 5 arguments gives the same result Included are a log of a run with all 5 arguments used, where i went to a server opened the gif browser and looked at some gif's to trigger the issue.

xmo-odoo commented 1 year ago

FWIW the clients downloaded directly from discord right now (both beta and stable) don't seem to have this issue, dunno if they already fixed them or something else. I didn't think to try that when I reported the issue originally.

lionirdeadman commented 1 year ago

Does this still happen on 0.0.27?

Bikutoso commented 1 year ago

@lionirdeadman I can confirm it's still present in 0.0.27

xmo-odoo commented 1 year ago

@lionirdeadman can also confirm, updated pak this morning, now running "stable 196448 (9260555) Host 0.0.27" and the issue still occurs.

Remove mentions of 0.0.26 in title (as well as comment talking about that) to match.

faelana commented 1 year ago

@Bikutoso @xmo-odoo I found a fix, i enabled it to run on wayland as per the README with flatpak override --user --socket=wayland com.discordapp.Discord and that fixed the flickering issue. Can anyone else affected test this too?

@TingPing If possible please consider adding a photosensitive warning and a mention to the fix, both here and on the flatpak metadata that shows on the website.

xmo-odoo commented 1 year ago

I found a fix, i enabled it to run on wayland as per the README with flatpak override --user --socket=wayland com.discordapp.Discord and that fixed the flickering issue. Can anyone else affected test this too?

Sadly that doesn't seem to work for me, which makes sense: Cinnamon (Mint's default DE) does not support wayland at all. Looking at the man page I assume all it does is allow discord to use wayland if that's available.

Bikutoso commented 11 months ago

I still have the issue in 0.0.28.

And i did just notice as i installed Discord on another computer i had it worked there without issues, so i do wonder what is different on machines having this issue to those who do not?

faelana commented 11 months ago

I still have the issue in 0.0.28.

And i did just notice as i installed Discord on another computer i had it worked there without issues, so i do wonder what is different on machines having this issue to those who do not?

@Bikutoso Hi, you should try my fix.

Bikutoso commented 9 months ago

I turned off Hardware Acceleration in Discord and it seems to have fixed the flashing. It's not optimal without it, but it should be better than running an out of date version

xmo-odoo commented 9 months ago

I turned off Hardware Acceleration in Discord and it seems to have fixed the flashing. It's not optimal without it, but it should be better than running an out of date version

Nice find, I can confirm that this also fixes the issue for me. On a machine which only has an intel integrated GPU (UHD Graphics 620)

MintMain21 commented 4 months ago

Using the Flatpak on the latest version of Linux Mint in February 2024. I want to use the app with Hardware Acceleration for optimal usability, but this bug persists. I thought enabling reduced motion would fix it but it doesn't.

I might transition to using the deb package from the official Discord website.

Might also have something to do with Swappiness, but I don't know.

TingPing commented 4 months ago

I might transition to using the deb package from the official Discord website.

Unless its a Mesa bug it should behave identical. Let us know if otherwise.

MintMain21 commented 4 months ago

Haven't been using the Deb package for long. In general it seems to work better, but the bug is more or less the same, just not as frequent.