Closed tfuxu closed 2 years ago
Build 113616 failed
I am not sure why you thought this would be part of the 0.3.1 release ? This should be pushed earlier.
Started test build 113619
I am not sure why you thought this would be part of the 0.3.1 release ? This should be pushed earlier.
I thought these PRs should only be made for new releases.
I am not sure why you thought this would be part of the 0.3.1 release ? This should be pushed earlier.
I thought these PRs should only be made for new releases.
Ah, I see :P ! Anyone can contribute to these, and a release is not needed for an update to flathub (it doesn't work like Fedora or Arch, a tag bump isn't needed for a new package version).
I was already preparing the switch to runtime 43, but, your update to sassc were very beneficial, and I wanted you to have credit for those.
+ The bug fix for the overrides.
Anyway, won't be able to review these tonight in more detail, unfortunately. I will leave that for tomorrow.
Build 113619 successful To test this build, install it from the testing repository:
flatpak install --user https://dl.flathub.org/build-repo/111225/com.github.GradienceTeam.Gradience.flatpakref
Woah, it compiled!
Started test build 113784
Build 113784 successful To test this build, install it from the testing repository:
flatpak install --user https://dl.flathub.org/build-repo/111394/com.github.GradienceTeam.Gradience.flatpakref
Thank you so much ! Merged !
you don't need to deal with -j4
if you use the standard build system. It wil do the right thing™.
-j4
is slower on the builders. Even on my laptop. Because they have more core/threads.
Uh... this now fails to build while it built yesterday, wat ?
Is it due to:
--filesystem=xdg-run/dconf
--filesystem=~/.config/dconf:ro
--talk-name=ca.desrt.dconf
--env=DCONF_USER_CONFIG_DIR=.config/dconf
?
the linter got activated today.
These dconf permissions should be gone. see https://docs.flatpak.org/en/latest/sandbox-permissions.html?highlight=dconf#dconf-access
Ah xD, bad luck I guess. And, yeah, that where I got my infos from.
they should never have been added.
Okay ! I was myself confused why they were there ! Good thing the linter got activated ! Should've asked why they were added, but assumed there was a reason behind it.
syncing from the upstream manifest seems to be the reason of all this havoc. And the syncing should have been the other way.
Yup, it was proposed to convert everything to YAML. I'll sync everything (the other way) at the same time.
Btw, you seem to be pretty present... everywhere :stuck_out_tongue: ! If we have any question about anything in flathub, can we ask you for advice ?
you should join the matrix channel instead.
I only saw this because I'm subscribed by default to all repository and unsubscribed as it goes (it's simpler). so I'll no longer get notifications here.
Oh ! Ok ! Thank you for your help !
Oh, wait, it still fails :/...
Does it really not like:
"--filesystem=xdg-data/flatpak/overrides:create",
Perhaps ? This was added to solve for functionality.
https://discourse.flathub.org/t/enforcing-pull-request-workflow-and-green-ci-status-of-prs/3109
you can apply for exceptions
Oh, indeed, it seems to be that!
Started test build 113616