Update XDG files - Githubissues

flathub / com.github.PintaProject.Pinta

https://flathub.org/apps/details/com.github.PintaProject.Pinta

2 stars 1 forks source link

Update XDG files #5

Closed scx closed 4 years ago

scx commented 4 years ago

Desktop file:

Add Version entry
Add TryExec entry
Add StartupWMClass entry
Add Keywords entry

AppData file:

Move categories and keywords to desktop file
Remove UserDocs from kudos because documentation is not bundled

Pinta.Install.proj:

Install AppData file

Update translations (XDG-only stuff):

de
en_GB

flathubbot commented 4 years ago

Started test build 10592

flathubbot commented 4 years ago

Build 10592 successful To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/10088/com.github.PintaProject.Pinta.flatpakref

TingPing commented 4 years ago

There is no point in adding TryExec btw.

scx commented 4 years ago

There is no point in adding TryExec btw.

It can matter for classic packages or if there is no packaging at all. And I don't see a reason for creating separate patches just for flatpak (IMHO it is a waste of time), so I just included the patch that is going to be upstreamed. Anyway, Flatpak can deal with TryExec without any problem. It basically removes this tag while exporting the desktop file.

https://github.com/flatpak/flatpak/blob/1.0.9/common/flatpak-dir.c#L5788

      g_key_file_remove_key (keyfile, groups[i], "TryExec", NULL);