flathub / com.github.micahflee.torbrowser-launcher

https://flathub.org/apps/details/com.github.micahflee.torbrowser-launcher
9 stars 12 forks source link

only create downloads #167

Closed boredsquirrel closed 1 year ago

boredsquirrel commented 1 year ago

I tested it, this permission is enough. Firefox doesnt even spit out an error but shows the download normally, and you can open it normally too! open the folder and from there open the file

boredsquirrel commented 1 year ago

when clicking on "show all downloads" it says "file moved or missing" but still shows it.

Personally I think this is okay, you can simply open the downloads folder and the file from there. But it is a tiny breakage of this function.

flathubbot commented 1 year ago

Started test build 61878

flathubbot commented 1 year ago

Build 61878 successful To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/44514/com.github.micahflee.torbrowser-launcher.flatpakref
AsciiWolf commented 1 year ago

@barthalion Why was this PR closed?

barthalion commented 1 year ago

Because the person who submitted did so in 39 other repositories, without any prior conversation, or even reading what filesystem permissions do.