flathub / com.github.tchx84.Flatseal

https://flathub.org/apps/details/com.github.tchx84.Flatseal
21 stars 6 forks source link

GNOME 3.38 and other minor elements #20

Closed Eonfge closed 4 years ago

Eonfge commented 4 years ago
flathubbot commented 4 years ago

Started test build 28333

flathubbot commented 4 years ago

Build 28333 successful To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/27280/com.github.tchx84.Flatseal.flatpakref
flathubbot commented 4 years ago

Started test build 28334

flathubbot commented 4 years ago

Build 28334 successful To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/27281/com.github.tchx84.Flatseal.flatpakref
Eonfge commented 4 years ago

@tchx84 Does this look good to you?

tchx84 commented 4 years ago

hey @Eonfge, can you send some of these changes upstream first ?

I already migrated to libhandy 1 there (which required more than just bumping the version).

EDIT: I am planning for a new release soon btw, so if we upstream first, these will be included in the next release anyway.

Eonfge commented 4 years ago

Hey, no problem. I'll make a pull request. You want both changes on different branches, or is one good for you?

tchx84 commented 4 years ago

Hey, no problem. I'll make a pull request. You want both changes on different branches, or is one good for you?

One PR is fine, different commits per lib/runtime if you feel like it :)

Eonfge commented 4 years ago

:sunglasses: https://github.com/tchx84/Flatseal/pull/146

tchx84 commented 4 years ago

Merged upstream PR.