search

flathub / com.github.themix_project.Oomox

https://flathub.org/apps/details/com.github.themix_project.Oomox
0 stars 5 forks source link

Can't export GNOME Shell Theme (need to specify the version) #7

Closed berkiyo closed 3 years ago

berkiyo commented 3 years ago

Hi there,

I've ran into an issue where if I try to export the GNOME Shell version of the Arc-style theme, it gives me this error.

gnome-oomox-bug-flatpak

I've tried running it like so, flatpak run com.github.themix_project.Oomox --with-gnome-shell=3.36, but no luck.

Any ideas?

actionless commented 3 years ago

@nana-4, do you have an idea how would be better to approach this case?

nana-4 commented 3 years ago

In Materia, we specify a default gnome-shell version as a fallback. Arc could also have a similar solution, I guess?

Or Oomox could add a theme option for Arc-style to specify a gnome-shell version, I think.

But I'm not the maintainer of Arc, and maybe @jnsh has a better idea.

jnsh commented 3 years ago

I was under the impression that Arc-theme support was dropped from oomox, at least for the fork I'm maintaining. Looks like the build error is coming from building the obsolete arc-design/arc-theme repo.

Regardless, in Arc there's no fallback version. If the version can't be determined for cinnamon, gnome-shell or gtk3, the build will fail to avoid incorrect theme versions from getting installed, unbeknownst to the user. This should be the same for the arc-design project.

IIRC, oomox didn't support recoloring GNOME Shell? If this is correct, maybe you could just disable the building of gnome-shell theme altogether. Same goes for rest of the themes that oomox don't support.

actionless commented 3 years ago

@nana-4 oops, i thought it was about Materia (because i remember it had some code for handling gnome version)

@jnsh , new people who started to maintain Arc-theme now have broken all the stuff, so in the next release it will be removed anyway: https://github.com/themix-project/oomox/issues/293