flathub / com.github.themix_project.Oomox

https://flathub.org/apps/details/com.github.themix_project.Oomox
0 stars 5 forks source link

Bump runtime to 42 and oomox to 1.14 #9

Closed bbhtt closed 2 years ago

bbhtt commented 2 years ago

This built and ran fine locally but I don't use the app, so needs testing to see if it still works.

It ran fine in native wayland, so I added support for it. If there are issues or wayland is unsupported entirely I can drop that change. :)

Ping @actionless, please review when you have time, thanks!

bbhtt commented 2 years ago

https://github.com/flathub/com.github.themix_project.Oomox/blob/95182c1329446f24d04f6150b840e2a1307d3f76/flathub.json#L2

Is skipping appstream validation still needed? There's no reason specified on why it is being skipped and the build logs from that time are gone

Running flatpak run --env=G_DEBUG=fatal-criticals org.freedesktop.appstream-glib validate *.xml locally, it passes. So I'm removing it. If there are issues I'll re-add.

bbhtt commented 2 years ago

bot, build

flathubbot commented 2 years ago

Queued test build for com.github.themix_project.Oomox.

flathubbot commented 2 years ago

Started test build 101336

flathubbot commented 2 years ago

Build 101336 failed

actionless commented 2 years ago

if i understood the log right, it's failing on this:

appstream-compose --prefix=/srv/buildbot/worker/build-x86_64/build/.flatpak-builder/rofiles/rofiles-FbyLAP/files --origin=flatpak --basename=com.github.themix_project.Oomox com.github.themix_project.Oomox

with many errors, main of which probably:

cannot open display: 
actionless commented 2 years ago

mb return back that appstream check thing

flathubbot commented 2 years ago

Started test build 101362

hfiguiere commented 2 years ago

if i understood the log right, it's failing on this:

appstream-compose --prefix=/srv/buildbot/worker/build-x86_64/build/.flatpak-builder/rofiles/rofiles-FbyLAP/files --origin=flatpak --basename=com.github.themix_project.Oomox com.github.themix_project.Oomox

with many errors, main of which probably:

cannot open display: 

these are harmless.

hfiguiere commented 2 years ago

I'm pretty this part:

                "mkdir -p /app/usr/share/",
                "ln -s /app/share/applications /app/usr/share/applications",
                "ln -s /app/share/appdata /app/usr/share/appdata",
                "ln -s /app/share/icons /app/usr/share/icons"

is part of the problem. /app/usr trigger bugs in appstream and has no reason to exist.

actionless commented 2 years ago

@hfiguiere i've tried to remove it - let's see

actionless commented 2 years ago

or mb actually this is the problem, not symlinks:

Error loading desktop file: Failed to find icon: Failed to find icon com.github.themix_project.Oomox
Error: ERROR: appstream-compose failed: Child process exited with code 1

but let's see if rebuilding without symlinks would help

actionless commented 2 years ago

bot, build

flathubbot commented 2 years ago

Queued test build for com.github.themix_project.Oomox.

flathubbot commented 2 years ago

Started test build 101365

actionless commented 2 years ago

thanks @hfiguiere it apparently helped

hfiguiere commented 2 years ago

thanks @hfiguiere it apparently helped

as I said, it triggers unfixed bugs in appstream-glib, and that's the root of the problems with icons when they actually are installed. In general /app/usr remain a bad idea, and is totally off the filesystem standards. (/app/opt as well btw)

flathubbot commented 2 years ago

Build 101362 failed

flathubbot commented 2 years ago

Build 101365 successful To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/99087/com.github.themix_project.Oomox.flatpakref
flathubbot commented 2 years ago

Started test build 101374

bbhtt commented 2 years ago

I squashed the i386 commits and cleaned up the remaining i386 build options. Hope you don't mind.

Thank you, both, for the reviews and suggestions!

actionless commented 2 years ago

thanks! please let me know if it will work for you after the build

flathubbot commented 2 years ago

Build 101374 successful To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/99096/com.github.themix_project.Oomox.flatpakref
bbhtt commented 2 years ago

Hi, I've tested it out with the bluloco theme, it can export those to ~/.themes and the icon theme in ~/.icons. Let me know if this is fine.

actionless commented 2 years ago

thanks @bbhtt let's see :)