Popover auto hide fix test

[flathubbot]

Started test build 65395

[flathubbot]

Build 65395 failed

[wwmm]

The tbb library is a new dependency. Let me know if it will be too hard to add it. On Arch Linux they are using tbb 2020.3 instead of the latest release. I do not know if there is a reason for that.

[flathubbot]

Started test build 65397

[vchernin]

I've tried the latest in the current build, some seem to have trouble with newer builds: https://github.com/flathub/org.cloudcompare.CloudCompare/blob/d2ac52a71eb0a6774267c9a5bafb9d1b2c1d21b3/org.cloudcompare.CloudCompare.yaml#L133

It's a bit concerning Arch is so far behind. Potentially some packages have incompatibilities with newer tbb so they left it on the older one.

If distros and Flathub use different tbb versions that sounds like potential for problems. But tbb is a useful looking library so I don't think it should be dropped because of this.

[wwmm]

For some reason tbb is required to use the parallel version of functions from c++ standard library. As the new convolver feature that allows impulse responses to be combined is being implemented with direct convolution I had to use the parallel version of the for loop to accelerated things a little bit.

[flathubbot]

Build 65397 successful To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/63211/com.github.wwmm.easyeffects.flatpakref

[vchernin]

Hm, even on Wayland I find the experience with autohide disabled to be not good. I was just trying to check settings and it was very strange not being able to click outside the popover to close settings. Escape doesn't work either. This seems like a tricky issue.

Maybe this new impulse menu is the only place autohide should be disabled?

Also with impulse responses, I found a UX quirk. If you try to combine 2 files but not give a name, it doesn't highlight the fact you missed a name. Admittedly it would be strange to not give it a name, but it's confusing if you forget and just try to combine impulses quickly.

tbb and combing impulses do seem to otherwise work though. I think it would be good to confirm why Arch and potentially other distros are behind updating it though.

Also, is it known that you can open both the Impulses and Combine menu at once? Is that intended or another bug?

[vchernin]

From reading bug reports this VFX issue seems to be blocking tbb 2021 from Arch: https://bugs.archlinux.org/task/46160#comment202742

[wwmm]

I was just trying to check settings and it was very strange not being able to click outside the popover to close settings.

I agree. It is annoying. In gtk3 the behavior was better. The popover was closed when clicking somewhere on the application window. Now when autohide is disabled only clicking on the menu button closes it.

Maybe this new impulse menu is the only place autohide should be disabled?

It is something to consider as it is not clear when the gtk4 bug I reported will be fixed.

If you try to combine 2 files but not give a name, it doesn't highlight the fact you missed a name.

Yes. I have to think about a way to notify the user about this.

is it known that you can open both the Impulses and Combine menu at once? Is that intended or another bug?

It is a side effect of disabling the autohide.

[vchernin]

Yes. I have to think about a way to notify the user about this.

A simple way could be to give the name box a red outline instead of blue when the user tries that, not sure how easy that is in GTK.

It is something to consider as it is not clear when the gtk4 bug I reported will be fixed.

Considering even if it was fixed today it will take time for a fix to make it to distros or the gnome runtime (for Flatpak), in my mind it is probably best to restore autohide for the other menus for now.

[wwmm]

A simple way could be to give the name box a red outline instead of blue when the user tries that, not sure how easy that is in GTK.

It would be nice. But I have the feeling it may not be an easy thing to do...

[wwmm]

In the end it was easy