search

flathub / com.github.wwmm.pulseeffects

https://flathub.org/apps/details/com.github.wwmm.pulseeffects
11 stars 6 forks source link

The .desktop file in flatpak tries to run "pulseeffects" directly instead of through flatpak #39

Closed promi closed 3 years ago

promi commented 3 years ago

When installing via flatpak (on Debian sid with GNOME), after restarting the desktop environment a menu item is shown for PulseEffects, but it does not work.

When I look at the .desktop file it has just "pulseeffects" as its run command, but on the command line I have to type:

flatpak run com.github.wwmm.pulseeffects

Is the .desktop file broken?

AsavarTzeth commented 3 years ago

That does seem broken. It should use Exec=/usr/bin/flatpak run --branch=stable --arch=x86_64 --command=pulseeffects com.github.wwmm.pulseeffects (for x86).

You may have already tried this but could you uninstall the app and verify that the .desktop file is removed? If not, remove it manually and reinstall. I have a vague memory of something similar happening to me at some point and I think I solved it that way.

wwmm commented 3 years ago

Ideally it would be good if the flatpak building process patched our `.desktop' files in the way that they need to be to be when used under flatpak. But if this is complicated for whatever reason we may consider adding to PulseEffects sources additional desktop files that work in Flatpak. But even them the building process would have to at least choosing the right files.

AsavarTzeth commented 3 years ago

The build process, specifically flatpak-builder already does that and have supported this for years; essentially from the beginning. What it does is it simply substitutes the value of Exec= with whatever is necessary, and using the reverse-dns id com.github.wwmm.pulseeffects as the new command.

I have no idea why it has broken in this particular case. To clarify if you do a clean install with flatpak install flathub com.github.wwmm.pulseeffects you will normally not have this issue.

promi commented 3 years ago

I am also at a loss, why it didn't work. After a clean install it works now. :)