search

flathub / com.github.wwmm.pulseeffects

https://flathub.org/apps/details/com.github.wwmm.pulseeffects
11 stars 6 forks source link

pulseeffects: Update to version 4.8.4 and add RNNoise module support #43

Closed RafaelKr closed 3 years ago

RafaelKr commented 3 years ago

this PR updates Pulseeffects to version 4.8.4

This also adds the xiph/rnnoise module to get the new Noise Reduction feature, which is awesome! Works even better than WebRTC.

Draft until I got a response from @wwmm regarding if there should be more dependency updates in issue https://github.com/wwmm/pulseeffects/issues/868#issuecomment-756439655

flathubbot commented 3 years ago

Started test build 36264

flathubbot commented 3 years ago

Build 36264 successful To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/34902/com.github.wwmm.pulseeffects.flatpakref
AsavarTzeth commented 3 years ago

Looks good! Much appreciated!

RafaelKr commented 3 years ago

Great! Thanks for merging so fast. How long does it usually take until it's available via Flathub?

AsavarTzeth commented 3 years ago

Not long. The bots immediately make a build, unless they are busy with other builds.

If you go to: https://github.com/flathub/com.github.wwmm.pulseeffects/commits/master

You can see a clickable green check mark (or some other symbol, dependent on status) next to the latest commit. From there it is easy to find all info from the build bots, live even.

In this case it seems to be done already, although in my experience it may take another few hours or at most a day until you see the update. If you want something more precise I would ask the Flathub maintainers.

P.S it went fast because I followed your discussion with upstream late last night (central EU time). My phone's email client had forgotten my do not disturb after bedtime setting :1st_place_medal:. Anyhow, I was prepared :)

RafaelKr commented 3 years ago

Okay, I saw that the builds were successful, but Flathub still lists 4.8.2, wasn't sure if the builds are enough or if you had to do some sort of release process besides the build.

When I try to update it says

...
F: Transaction: install/update flathub:runtime/org.freedesktop.Platform.Locale/x86_64/1.6[/de, /en]
F: Transaction: install/update flathub:runtime/com.github.wwmm.pulseeffects.Locale/x86_64/stable[/de, /en]
F: flathub:x86_64 appstream age 74349 is less than ttl 86400

So maybe it's available in (86400−74349)÷60 = 200,85 minutes which are around 3,5 hours? So I'm just waiting now and check it then :)

Oh, I hope you slept well anyway! :)