search

flathub / com.googleplaymusicdesktopplayer.GPMDP

https://flathub.org/apps/details/com.googleplaymusicdesktopplayer.GPMDP
4 stars 5 forks source link

Version bump to release 4.7.1 #17

Closed tante closed 4 years ago

tante commented 4 years ago

Version bump to new release.

flathubbot commented 4 years ago

Started test build 13465

flathubbot commented 4 years ago

Build 13465 failed

flathubbot commented 4 years ago

Started test build 13466

flathubbot commented 4 years ago

Build 13466 failed

flathubbot commented 4 years ago

Started test build 13485

flathubbot commented 4 years ago

Build 13485 failed

flathubbot commented 4 years ago

Started test build 13520

flathubbot commented 4 years ago

Build 13520 failed

akadrac commented 4 years ago

@tante change the "mv /app/share/pixmaps/google-play-music-desktop-player.png" to cp. as you are doing it twice.

flathubbot commented 4 years ago

Started test build 13757

flathubbot commented 4 years ago

Build 13757 failed

flathubbot commented 4 years ago

Started test build 13758

flathubbot commented 4 years ago

Build 13758 failed

akadrac commented 4 years ago

@tante seems like the "rename-icon" in line 11 is causing the issue, maybe comment it out and see?

flathubbot commented 4 years ago

Started test build 13762

flathubbot commented 4 years ago

Build 13762 successful To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/13139/com.googleplaymusicdesktopplayer.GPMDP.flatpakref
tante commented 4 years ago

Tested the Test build on my machine. Works.

flathubbot commented 4 years ago

Started test build 13818

flathubbot commented 4 years ago

Build 13818 failed

tante commented 4 years ago

So with the name-mangling back in the game I see the error message I had before: Renaming icon hicolor/1024x1024/apps/google-play-music-desktop-player.png to hicolor/1024x1024/apps/com.googleplaymusicdesktopplayer.GPMDP.png Rewriting contents of com.googleplaymusicdesktopplayer.GPMDP.desktop Running appstream-compose FB: Running: flatpak build --die-with-parent --nofilesystem=host /srv/buildbot/worker/build-i386-2/build/.flatpak-builder/rofiles/rofiles-0wqOAj appstream-compose --prefix=/app --origin=flatpak --basename=com.googleplaymusicdesktopplayer.GPMDP com.googleplaymusicdesktopplayer.GPMDP Processing application com.googleplaymusicdesktopplayer.GPMDP Error loading desktop file: Failed to find icon: Failed to find icon com.googleplaymusicdesktopplayer.GPMDP

Does the desktop file loader have issues with the new folder (1024x1024 instead of 512x512)? because I checked and all file names and references check out.

TingPing commented 4 years ago

Yes 1024 isn't a known size.

TingPing commented 4 years ago

Pushed an update fixing the icon.