search

flathub / com.hostbuf.FinalShell

https://flathub.org/apps/details/com.hostbuf.FinalShell
10 stars 1 forks source link

Description language #3

Closed razzeee closed 1 year ago

razzeee commented 1 year ago

It would be good to separate out the japanese description to it's own translated version and not have it in the english one. https://github.com/flathub/com.hostbuf.FinalShell/blob/master/com.hostbuf.FinalShell.metainfo.xml#L9

For e.g. https://www.freedesktop.org/software/appstream/docs/chap-CatalogData.html#spec-asxml-example

So something like this should work:

 <description lang="jp">Translation</description>
razzeee commented 1 year ago

You can also markup the <p> statements like that. But I think that might not display correctly on the website right now. But should in software centers.

jcleng commented 1 year ago

i see there tag-ct-languages and is Chinese use zh or zh-Hans ? from flathub.org/zh-Hans

razzeee commented 1 year ago

The website currently only handles English app texts

jcleng commented 1 year ago

@razzeee https://github.com/flathub/com.hostbuf.FinalShell/blob/c66c08c0a88b30886f044288592953c6001692c7/com.hostbuf.FinalShell.metainfo.xml#L34 https://flathub.org/apps/com.hostbuf.FinalShell Not effective

razzeee commented 1 year ago

Sorry, I think it needs to be

 <description xml:lang="zh">

See for e.g. https://github.com/flathub/org.squeakland.Etoys/blob/ee652281db980d33778b31228e36cb142ff67fbe/org.squeakland.Etoys.metainfo.xml#L57

That's a specific reference, but just zh should also work, I think.

jcleng commented 1 year ago

not effective for website, xml:lang or lang, may be only software centers of desktop.

razzeee commented 1 year ago

Looks good on the website now. Thx!