search

flathub / com.jagex.RuneScape

https://flathub.org/apps/details/com.jagex.RuneScape
20 stars 13 forks source link

Fullscreen window not visible on workspace #139

Open maxice8 opened 3 years ago

maxice8 commented 3 years ago

OS: Fedora SilverBlue DE: GNOME 3.38 (No Extensions) Wayland

  1. Have Fullscreen on graphics
  2. Make runescape only window in a workspace
  3. Switch away from it
  4. Switch to it
  5. Runescape should not be visible, requiring an Alt+Tab or another way to get focus

Same does not happen it other Flatpak'd applications like Celluloid

Garbee commented 3 years ago

Does it happen in regular Fedora or can you test in SilverBlue with the official packages from Jagex? It could very well be a Jagex problem and not anything to do with the flatpak wrapper.

maxice8 commented 3 years ago

I'll test the official package from Jagex

JGCarroll commented 3 years ago

It's an SDL setting you can fix with SDL_VIDEO_MINIMIZE_ON_FOCUS_LOSS=0, I also pitched the idea to Mod Dark a while back to make it default, it could be easily exported in the Flatpak next to the Pulse latency fix. The Jagex package will have the undesirable behaviour.

The SDL_VIDEO_MINIMIZE_ON_FOCUS_LOSS=0 behaviour is default on Windows too. I made it default on the Snap several months ago and no one has complained it's broken anything yet so there's no real consequence from what I can tell. https://github.com/MrCarroll/runescape-snap/issues/4

maxice8 commented 3 years ago

Yep, fixes it. Thanks!

Garbee commented 3 years ago

I'd rather keep the env vars we set minimal. Things like this I'd rather have documented for people to apply on their own as-needed. Should Jagex wish to make it default, then that's on their QA team to deal with (should they actually do any QA.)