search

flathub / com.jagex.RuneScape

https://flathub.org/apps/details/com.jagex.RuneScape
20 stars 13 forks source link

Update runescape.deb to 2.2.8 #145

Closed flathubbot closed 3 years ago

flathubbot commented 3 years ago

(This pull request was automatically generated by flathub/flatpak-external-data-checker. Please contact or mention @barthalion or @wjt if you have any questions or complaints.)

flathubbot commented 3 years ago

Started test build 39370

flathubbot commented 3 years ago

Build 39370 failed

Garbee commented 3 years ago

Hmm, looks like Jagex released a patch release without bumping the version. Which the bot auto-consumes to set the release version for the flatpack package. And that is a problem since the server wants unique versions.

I'll look into this a bit this evening and see what might be doable here. Perhaps the upstream bot will need a patch to detect a previous version of the same and if it exists add our own dot version incrimenting upwards.

cc @barthalion at least for some awereness here. As one of the maintainers of the bot/flathub may know a solution to this faster than me looking over it.

barthalion commented 3 years ago

cc @gasinvein

(Sorry for passing the ball but Filippe does the majority of fedc work these days.)

gasinvein commented 3 years ago

I think the issue here is that flatpak-external-data-checker adds a release entry into appdata despite the version didn't change. The tricky part is that we don't keep record of current version, and, thus, will have to either compare urls or peek into the appdata file to check if the "new" version is already there.

gasinvein commented 3 years ago

In any case, please file a bug to https://github.com/flathub/flatpak-external-data-checker/issues to keep track of this.

gasinvein commented 3 years ago

Proposed a fix flathub/flatpak-external-data-checker#139, review welcome.

Garbee commented 3 years ago

Whoops, I completely forgot about this over the weekend.

Yea that fix looks like exactly what we need, just adding an extra revision to the version number. Thank you!

gasinvein commented 3 years ago

I don't think we should increment version in appdata release when there is no new upstream versions. Besides, updating .deb without release bump is just wrong, upstream shouldn't be doing this in the first place.

Garbee commented 3 years ago

Yea I may have misread the code. The last commit for this version worked though and didn't add another incriment.

upstream shouldn't be doing this in the first place

Well, I'd love for someone to inform Jagex of how to properly develop and distribute software. But they're very keen on not listening. So we just need to do the best we can around it.

gasinvein commented 3 years ago

Why do you even want a release counter in the appdata? It's for informational purposes anyway, appdata releases don't affect the way how flatpaks are updated.

Garbee commented 3 years ago

To be honest, I don't care as long as the automated builds work.