search

flathub / com.jetbrains.CLion

https://flathub.org/apps/details/com.jetbrains.CLion
8 stars 8 forks source link

Change in build 114601 rejected #84

Closed flathubbot closed 2 months ago

flathubbot commented 2 months ago

A change in build 114601 has been reviewed by the Flathub team, and rejected for the following reason:

Please explain why pulseaudio and pipewire permissions are needed. https://github.com/flathub/com.jetbrains.CLion/pull/83 has no reference to why they'd be required.

Changes

Field Old value New value
sockets ['gpg-agent', 'ssh-auth', 'wayland', 'x11'] ['gpg-agent', 'pulseaudio', 'ssh-auth', 'wayland', 'x11']
filesystems ['host', 'xdg-run/app/com.discordapp.Discord:create', 'xdg-run/docker', 'xdg-run/gnupg:ro', 'xdg-run/keyring', 'xdg-run/podman'] ['host', 'xdg-run/app/com.discordapp.Discord:create', 'xdg-run/docker', 'xdg-run/gnupg:ro', 'xdg-run/keyring', 'xdg-run/pipewire-0:ro', 'xdg-run/podman']
appelgriebsch commented 2 months ago

I was just following up on the recent changes in IntelliJ IDEA flatpaks -> https://github.com/flathub/com.jetbrains.IntelliJ-IDEA-Community/pull/168, https://github.com/flathub/com.jetbrains.IntelliJ-IDEA-Ultimate/pull/188

bbhtt commented 2 months ago

Does this app actually need it? Did you check?

appelgriebsch commented 2 months ago

No I haven't as this issue seems to be only affecting specific distributions. I was rather seeing this as general quality of life improvement as most other Jetbrains flatpaks also have the pulseaudio setting activated.

If that's the only reason to reject the release, will revert the change later today...

bbhtt commented 2 months ago

If this app doesn't need it it is better to not add the permission.