flathub / com.jetbrains.PyCharm-Community

https://flathub.org/apps/details/com.jetbrains.PyCharm-Community
11 stars 9 forks source link

Add Zypak #534

Closed FakeShemp closed 1 year ago

flathubbot commented 1 year ago

Started test build 33191

flathubbot commented 1 year ago

Build 33191 successful To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/15826/com.jetbrains.PyCharm-Community.flatpakref
freeseacher commented 1 year ago

As a result of integration of zypak like this every command made in shell is surrounded with image

also i've got dbus error on most launches.

that is pretty annoying. i haven't found a solution for this and decided not to use it.

refi64 commented 1 year ago

This PR is pretty much entirely broken, it's calling Zypak on the outermost wrapper script, meaning its hooks end up applying to bash and PyCharm itself (inc. the entire JVM) and the entire terminal and everything inside.

It should probably be attaching to jcef_helper, the actual Chromium-using binary in question...unfortunately, that does not seem to work, and I'm not sure why yet. Regardless, this should be reverted in the mean time and the update should just be rolled back.

refi64 commented 1 year ago

Filed https://github.com/refi64/zypak/issues/31 to figure out how to make this work.

refi64 commented 1 year ago

Well this is significantly uglier than I expected to work around... In the mean time, for the record, the goland PR just disables the jcef sandboxing, which is a much better workaround for now.