search

flathub / com.kristianduske.TrenchBroom

https://flathub.org/apps/details/com.kristianduske.TrenchBroom
3 stars 4 forks source link

Update to Trenchbroom 2023.1 release #8

Open Sinihopea opened 1 year ago

Sinihopea commented 1 year ago

Hopefully everything works out alright.

flathubbot commented 1 year ago

Started test build 51141

Sinihopea commented 1 year ago

Hmm... Is that CMake patch still necessary? Seems like it caused test build to hang up.

flathubbot commented 1 year ago

Build 51141 failed

flathubbot commented 1 year ago

Started test build 51159

flathubbot commented 1 year ago

Build 51159 failed

Sinihopea commented 1 year ago

Hmmm... Somekind of error related to vcpkg.

flathubbot commented 1 year ago

Started test build 51162

Sinihopea commented 1 year ago

Ok, so how do I bring vcpkg stuff into the Flatpak without having an internet access?

flathubbot commented 1 year ago

Build 51162 failed

tesfabpel commented 1 year ago

Ok, so how do I bring vcpkg stuff into the Flatpak without having an internet access?

I've seen this Rust app that's on flathub and it has a generated-sources.json file which is generated from all the dependencies and in the manifest it uses cargo --offline <command> when it needs to use cargo, to avoid using the network...

IDK if vcpkg allows something similar, but probably using it in manifest mode opens some ways (EDIT: maybe by populating the vcpkg/downloads folder?)...

tesfabpel commented 1 year ago

Uhm, I'm actually trying to make vcpkg work under flatpak just for curiosity and I've got some progresses in my fork: https://github.com/tesfabpel/com.kristianduske.TrenchBroom/tree/v2023.1-update, it's tedious but the build seems to progress... It's a WIP and still not done, though... ;)

EDIT: I've amended the commit and now all the dependencies declared in vcpkg seems to download and build... Sadly, after that, it can't find other modules declared in flatpak... I don't think I know how to continue from now on...

kduske commented 1 year ago

We have already made some exceptions on Linux for libraries which we can safely install via package managers without conflicts such as freeimage. Maybe we could do this for all libraries on Linux.