search

flathub / com.makemkv.MakeMKV

https://flathub.org/apps/details/com.makemkv.MakeMKV
9 stars 20 forks source link

Fix SVQ download #12

Closed jstebbins closed 5 years ago

jstebbins commented 5 years ago

Allows SVQ downloads and fixes log message Automatic SVQ downloading is disabled or failed

SVQ download requires wget which the kde flatpak runtime does not provide. Also, makemkv hardcodes the path to /usr/bin/wget. So patch makemkv to use $PATH

SVQ files are required for some BD+ discs, see https://www.makemkv.com/svq/

flathubbot commented 5 years ago

Started test build 4580

flathubbot commented 5 years ago

Build 4580 failed

jstebbins commented 5 years ago

Strange, builds just fine locally It's failing to untar/unzip wget

]2;flatpak-builder: Building wgetFB: Running: tar xf /srv/buildbot/worker/build-x86_64-4/build/.flatpak-builder/downloads/69607ce8216c2d1126b7a872db594b3f21e511e660e07ca1f81be96650932abb/wget-1.20.3.tar.lz --no-same-owner --strip-components=1 --lzip
tar (child): lzip: Cannot exec: No such file or directory
tar (child): Error is not recoverable: exiting now

local build

FB: Running: tar xf /home/jstebbins/Source/MakeMKV/com.makemkv.MakeMKV/.flatpak-builder/downloads/69607ce8216c2d1126b7a872db594b3f21e511e660e07ca1f81be96650932abb/wget-1.20.3.tar.lz --no-same-owner --strip-components=1 --lzip
FB: Running: flatpak build --die-with-parent --env=FLATPAK_BUILDER_BUILDDIR=/run/build/wget --nofilesystem=host --filesystem=/home/jstebbins/Source/MakeMKV/com.makemkv.MakeMKV/.flatpak-builder/build/wget-1 --bind-mount=/run/build/wget=/home/jstebbins/Source/MakeMKV/com.makemkv.MakeMKV/.flatpak-builder/build/wget-1 --build-dir=/run/build/wget --bind-mount=/run/ccache=/home/jstebbins/Source/MakeMKV/com.makemkv.MakeMKV/.flatpak-builder/ccache --env=SOURCE_DATE_EPOCH=1560522722 '--env=CFLAGS=-march=x86-64 -mtune=generic -O2 -g -pipe -Wp,-D_FORTIFY_SOURCE=2 -Wp,-D_GLIBCXX_ASSERTIONS -fexceptions -fstack-protector-strong -grecord-gcc-switches -fasynchronous-unwind-tables -fstack-clash-protection -fcf-protection' '--env=CXXFLAGS=-march=x86-64 -mtune=generic -O2 -g -pipe -Wp,-D_FORTIFY_SOURCE=2 -Wp,-D_GLIBCXX_ASSERTIONS -fexceptions -fstack-protector-strong -grecord-gcc-switches -fasynchronous-unwind-tables -fstack-clash-protection -fcf-protection' '--env=LDFLAGS=-L/app/lib -Wl,-z,relro,-z,now -Wl,--as-needed' --env=CCACHE_DIR=/run/ccache/disabled --env=PATH=/app/bin:/usr/bin:/usr/lib/sdk/openjdk10/bin --env=LD_LIBRARY_PATH=/app/lib --env=PKG_CONFIG_PATH=/app/lib/pkgconfig:/app/share/pkgconfig:/usr/lib/pkgconfig:/usr/share/pkgconfig --env=FLATPAK_BUILDER_N_JOBS=8 /home/jstebbins/Source/MakeMKV/com.makemkv.MakeMKV/.flatpak-builder/rofiles/rofiles-HTkZWq ./configure --prefix=/app

I thought flatpak-build did the build in a sandbox where the environment would be the same regardless of where it is built. I guess that is not entirely the case?

If necessary this can be "fixed" by using the gz version of the wget tar. It's more than twice as large though.

flathubbot commented 5 years ago

Started test build 4584

flathubbot commented 5 years ago

Build 4584 successful To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/4383/com.makemkv.MakeMKV.flatpakref
flathubbot commented 5 years ago

Started test build 5362

flathubbot commented 5 years ago

Build 5362 successful To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/5142/com.makemkv.MakeMKV.flatpakref