search

flathub / com.makemkv.MakeMKV

https://flathub.org/apps/details/com.makemkv.MakeMKV
9 stars 20 forks source link

Project license should link to license #3

Open hadess opened 5 years ago

hadess commented 5 years ago

The appdata just says:

    <project_license>LicenseRef-proprietary AND GPL-2.0 AND LGPL-2.1-only</project_license>

Ideally this would link to the license online, similarly to those other projects on Flathub:

    <project_license>LicenseRef-proprietary=https://botfather.io/docs/legal/tos/</project_license>
    <project_license>LicenseRef-proprietary=https://code.visualstudio.com/license</project_license>
    <project_license>LicenseRef-proprietary=https://raw.githubusercontent.com/snes9xgit/snes9x/master/docs/snes9x-license.txt AND LGPL-2.1</project_license>
    <project_license>LicenseRef-proprietary=https://wwwimages2.adobe.com/content/dam/acom/en/legal/licenses-terms/pdf/Flash_Player_30_0.pdf</project_license>
    <project_license>LicenseRef-proprietary=https://www.spotify.com/us/legal/end-user-agreement/</project_license>
    <project_license>LicenseRef-proprietary=https://www.sublimetext.com/eula</project_license>
wberrier commented 5 years ago

I agree, and when originally created the appdata intended to do so, but was unable to find a url to the license text.

hadess commented 5 years ago

Maybe https://www.makemkv.com/buy/ would be good enough?

wberrier commented 5 years ago

I don't have strong objections to that, but putting a "purchase" link inside a license link seems a bit of a misuse... ? Thoughts?

I could also ask the developer to post the license on his website and link to that.

ablackbu commented 5 years ago

For what its worth the license is in the bin release so I would imagine you have it every time you update the flatpak based on the way it is packed into the bin. For example on 1.14.2 release -> makemkv-bin-1.14.2/src/eula_en_linux.txt