Update sdk, makemkv, ffmpeg and openjdk

[flathubbot]

Started test build 1932

[flathubbot]

Build 1932 failed

[flathubbot]

Started test build 1941

[flathubbot]

Build 1941 successful To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/114381/com.makemkv.MakeMKV.flatpakref

[Perkolator]

Please merge. Flatpak of MakeMKV has been lagging behind so many times. I don't want to sound ungrateful but it would be nice to have faster updates. Any way to automate? MANY THANKS for making this flatpak package!

[flathubbot]

Started test build 2125

[lhw]

Please merge. Flatpak of MakeMKV has been lagging behind so many times. I don't want to sound ungrateful but it would be nice to have faster updates. Any way to automate? MANY THANKS for making this flatpak package!

Done. Now the versions would automatically update via PR for the important stuff.

[flathubbot]

Build 2125 successful To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/114563/com.makemkv.MakeMKV.flatpakref

[wberrier]

Thanks for the pull request, the yaml is much nicer than the json :+1:

Please merge. Flatpak of MakeMKV has been lagging behind so many times. I don't want to sound ungrateful but it would be nice to have faster updates. Any way to automate? MANY THANKS for making this flatpak package!

Any help in updating versions is greatly appreciated ;)

Once conflicts have been resolved and all majors features have been tested with these new updates this can be merged.

Thanks!

[lhw]

Once conflicts have been resolved and all majors features have been tested with these new updates this can be merged.

Updated accordingly. I already had that change in anyway.

Any help in updating versions is greatly appreciated ;)

The new yaml comes with the flatpak-external-data-checker built-in. It will automatically create a PR on this repo with the new file links and hashsums. And in case you want it (flathub.json change) also merge it when the build succeeds.

[flathubbot]

Started test build 2317

[flathubbot]

Build 2317 successful To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/114757/com.makemkv.MakeMKV.flatpakref

[Perkolator]

I don't understand how this system works (and thus I don't know how to help), but is there still a problem? I can't see the update.

[lhw]

I don't understand how this system works (and thus I don't know how to help), but is there still a problem? I can't see the update.

It's not merged yet. The link provided by the flathubbot is just for testing convenience. Its basically a nightly build with just the change from this PR

[Perkolator]

What gives? I've been putting off ripping my new discs waiting for this update. What is needed to make this update happen?

[flathubbot]

Started test build 5486

[flathubbot]

Build 5486 successful To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/117928/com.makemkv.MakeMKV.flatpakref

[flathubbot]

Started test build 5489

[flathubbot]

Build 5489 successful To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/117931/com.makemkv.MakeMKV.flatpakref

[wberrier]

Thanks @lhw for the pull request and the great changes. I really like the idea of automatically creating merge requests when the versions are updated. And again, the yaml is much nicer to work with. Thank you for testing out this build.

@michaelkuhn thank you for the in depth review :bow:

Let's get this merged once the "auto merge" flag is turned off.

I apologize for the delay of getting this reviewed and merged. Here are some tips that could have gotten this merged faster:

• put format changes in a separate pull request with no other changes: json -> yaml
• put version updates in a separate pull request
• put controversial changes in separate pull requests

Granted, most of these pull requests would have need to be tested and validated, so I guess you could argue it's nice testing only one build, although I do think these would have been reviewed and merged more quickly if done as suggested above.

Cheers!

[flathubbot]

Started test build 5710

[flathubbot]

Build 5710 successful To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/118155/com.makemkv.MakeMKV.flatpakref

[wberrier]

Thanks again @lhw :+1: