flathub / com.makemkv.MakeMKV

https://flathub.org/apps/details/com.makemkv.MakeMKV
9 stars 20 forks source link

Restrict default filesystem access to ~/.MakeMKV and ~/Videos #70

Open joshua-stone opened 8 months ago

joshua-stone commented 8 months ago

Qt can use the file picker portal to gain write access to specific directories from within the sandbox.

This seems to work for scenarios like:

flathubbot commented 8 months ago

Started test build 83180

flathubbot commented 8 months ago

Build 83180 successful To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/65815/com.makemkv.MakeMKV.flatpakref
joshua-stone commented 8 months ago

Filesystem access can be tested by setting a data directory through the file picker:

$ flatpak run --nofilesystem=home --filesystem='~/.MakeMKV:create' com.makemkv.MakeMKV

image

Then run find on the directory:

$ flatpak run --nofilesystem=home --filesystem='~/.MakeMKV:create' --command=sh com.makemkv.MakeMKV -c 'grep app_DataDir ~/.MakeMKV/settings.conf | cut -f2 -d \" | xargs find'
/run/user/1000/doc/7a8a5adb/.MakeMKV.test
/run/user/1000/doc/7a8a5adb/.MakeMKV.test/_private_data.tar
flathubbot commented 8 months ago

Started test build 83597

flathubbot commented 8 months ago

Build 83597 successful To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/66230/com.makemkv.MakeMKV.flatpakref
nalsai commented 4 weeks ago

Wouldn't persist instead of filesystem be better for ~/.MakeMKV, or is there a reason it needs filesystem?

flathubbot commented 4 weeks ago

Started test build 130227

flathubbot commented 4 weeks ago

Build 130227 failed