search

flathub / com.mojang.Minecraft

https://flathub.org/apps/details/com.mojang.Minecraft
32 stars 13 forks source link

Set LC_ALL=C env variable #138

Closed SystemlessDev closed 1 year ago

SystemlessDev commented 1 year ago

Fixes #6 and #25

The minecraft launcher doesn't seem to pick the language after what locale the system has set. I am at least not able to make it select norwegian bokmål automatically.

When it comes to the env variable it wants us to set. It doesn't care about any of the LC_* variables. It wants LANG to be set to something it knows. Setting it to nn_NO.UTF-8 (norwegian nynorsk) makes it crash, however with nb_NO (norwegian bokmål) it launches fine.

Considering how it doesn't care about the system locale after all I think it's the best to just set LC_ALL=C and call it a day.

flathubbot commented 1 year ago

Started test build 18783

flathubbot commented 1 year ago

Build 18783 successful To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/1409/com.mojang.Minecraft.flatpakref
SystemlessDev commented 1 year ago

@AsciiWolf Do you agree with this change being made? I have tested it and it works fine.

AsciiWolf commented 1 year ago

I am not sure. This will ideally need further testing before being merged.

SystemlessDev commented 1 year ago

I have now tested this PR further and haven't been able to make it break. So I am assuming that it's completely fine. This assumption is also backed up by the fact that it's a known workaround for this issue already (from the info given in the issues I have linked to)