search

flathub / com.mojang.Minecraft

https://flathub.org/apps/details/com.mojang.Minecraft
34 stars 13 forks source link

Launcher Update Available #76

Closed Justinzobel closed 3 years ago

Justinzobel commented 3 years ago

Title says it all, thanks for the great work!

AsciiWolf commented 3 years ago

Thanks! Client updates are handled automatically by x-data-checker - PR is created by a bot when an update is available. I wonder why it was not created yet, but it will surely be updated in upcoming days.

AsciiWolf commented 3 years ago

Hmm, I wonder why the PR was not created yet. Maybe the x-data-checker bot has some issues.

AsciiWolf commented 3 years ago

/cc @wjt @bilelmoussaoui

wjt commented 3 years ago

I don't know about Bilal but I don't have access to the bot's logs AFAIK. @barthalion @gasinvein are you able to look at what's happening?

gasinvein commented 3 years ago

@wjt Logs are available to everyone at the flathub repo actions.

@AsciiWolf Your x-checker-data results in constructing URLs with http 404. Maybe updstream files are served from a different URL now? In the meantime, you can use/test flatpak-external-data-checker locally, it's available as a flatpak and as docker image.

AsciiWolf commented 3 years ago

So, it looks like that the naming scheme for Minecraft Launcher has changed, but the json file we parse did not follow this change and is still using the old one. This page also still uses the old naming scheme and shows 2.2.2159 as the latest Linux version. But the actual latest package version is 887, according to the official Arch Linux AUR package. I will update the Flatpak manually and keep this issue open until a proper solution is found.

AsciiWolf commented 3 years ago

Hmm, actually, it looks like the json file has the 887 version entry. So, the only thing we probably need to fix is the x-data-checker version-pattern.

gasinvein commented 3 years ago

Once you figure out Mincraft versions, consider also switching to the json checker (based on jq). It allows you to to process json structure and is much more precise than a regex.

AsciiWolf commented 3 years ago

Thanks. I have prepared the manual update, see #78, unfortunately it does not seem to work. I will fix the x-data-checker after this is resolved.