Experimental native Wayland Support

vchernin commented 3 years ago

Adds native Wayland support thanks to the work that's gathered here. Nothing is changed by default, a user specifically has to opt in by adding a JVM flag in the launcher. Should work in 1.13+, including 1.17 (see picture).

This is done so the GLFW patches can be tested. The goal is not to have to ship a patched GLFW, but to help get them upstreamed.

Fixes #84

Minecraft in Native Wayland

To use:

Install with flatpak install --user https://dl.flathub.org/build-repo/50928/com.mojang.Minecraft.flatpakref
- Or git clone my repo and then flatpak-builder --user --install build-dir com.mojang.Minecraft.json
Within the Minecraft launcher’s "Installations" menu, hover over an installation and click the 3 dots. Click edit, and then open advanced options near the bottom. Append -Dorg.lwjgl.glfw.libname=/home/<user>/.local/share/flatpak/app/com.mojang.Minecraft/current/active/files/lib/libglfw.so to your JVM arguments.
- Ensure to replace <user> with your username, and to leave a space in between arguments. Fedora Silverblue users should add /var at the beginning. If you install without --user the GLFW directory will be different, so adding the JVM argument will stop Java from launching.
Click play!

Issues:

[x] No proper decorations on GNOME Wayland.
I have been unable to include the patch for libdecoration. It appears the patch itself is broken, but I am trying to confirm that.
Until then GNOME users will likely not have a great experience, since Minecraft does not have CSD support without the patch.
Even when this patch is merged we still won't have gtk-style window decorations, to do so the GLFW patch needs to be updated to use this libdecoration change.
[x] Weird rectangle that shows up on my HIDPI monitor in GNOME Wayland.
Only occurs when libdecor is not included.
[ ] The only way I know to get the JVM to use the patched GLFW is with the instructions above. I don't know how to set JVM flags within the Flatpak config. For now we shouldn't anyhow, but it is something I'd like to figure out.
The flag appended requires manually setting your user, $USER doesn't work. This should be improved somehow.
[ ] The way I give Minecraft permission in 7c025f1 to read the patched library is not ideal. It took me a while to figure out what exactly I needed to give it. I feel like this is a bug, since shouldn't the Flatpak always have permission to read it's own directories?
The .local directory is given in case it's installed with for a user, the other is in case it's installed system-wide.
[ ] On my HIDPI setup, Minecraft seems to incorrectly always pick my smaller and lower resolution monitor when clicking fullscreen within the game settings. The only way to override this behaviour is to disable the lower resolution monitor.
[ ] Sometimes the cursor gets displaced when full screening. If this happens you can try unfullscreening by using tab and arrow keys to navigate controls.
[ ] There is a general blur to their entire window when libdecor is there. Compare them using this diff, click "Swipe" at the bottom. The image on the right is with the libdecor patch, the one on the left is without. You might need to zoom in if it's not obvious.

Patch Info:

The Flatpak uses the patches gathered here (libdecoration branch), which were originally from the following GLFW changes:	Patch	Original PR/Commit
0001	PR	Add libdecoration support to get CSD on GNOME
0002	PR	Fixes freeze caused by race condition
0003	Commit	Don't crash on window focus or icons
0004	Commit	Fixes broken Mutter (GNOME) OpenGL screenshots

Todo:

Debug issues and report them upstream.

vchernin commented 3 years ago

bot, build

flathubbot commented 3 years ago

Queued test build for com.mojang.Minecraft.

flathubbot commented 3 years ago

Started test build 52190

flathubbot commented 3 years ago

Build 52190 successful To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/50191/com.mojang.Minecraft.flatpakref

flathubbot commented 3 years ago

Started test build 52197

flathubbot commented 3 years ago

Build 52197 successful To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/50196/com.mojang.Minecraft.flatpakref

flathubbot commented 3 years ago

Started test build 52198

flathubbot commented 3 years ago

Build 52198 successful To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/50197/com.mojang.Minecraft.flatpakref

flathubbot commented 3 years ago

Started test build 52254

flathubbot commented 3 years ago

Build 52254 successful To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/50252/com.mojang.Minecraft.flatpakref

vchernin commented 3 years ago

bot, build

flathubbot commented 3 years ago

Queued test build for com.mojang.Minecraft.

flathubbot commented 3 years ago

Started test build 52968

flathubbot commented 3 years ago

Build 52968 successful To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/50928/com.mojang.Minecraft.flatpakref

AsciiWolf commented 3 years ago

Please, rebase this PR against the latest json file from master. Your current one has a lot of changes that are different in the current master. Thanks!

vchernin commented 3 years ago

Latest PR https://github.com/flathub/com.mojang.Minecraft/pull/96

flathubbot commented 3 years ago

Started test build 54018

flathubbot commented 3 years ago

Build 54018 failed

flathub / com.mojang.Minecraft