search

flathub / com.mongodb.Compass

https://flathub.org/apps/details/com.mongodb.Compass
7 stars 3 forks source link

EOL support thread #28

Closed JavkhlanK closed 1 year ago

JavkhlanK commented 1 year ago

I noticed this wrapper was discontinued. What exactly are the incompatibilities? I found one that starting with 1.38.0 the release file structure was slightly changed. But is that all?
After quickly fixing the .json file to not copy main and to instead copy main/MongoDB Compass-linux-x64 to /app/main and running a local build, the app launched normally for me.

dominikzogg commented 1 year ago

https://github.com/flathub/com.mongodb.Compass/pull/29

mijorus commented 1 year ago

this is not the first time that happens...

dominikzogg commented 1 year ago

@mijorus https://github.com/flathub/com.mongodb.Compass/pull/29 fixes this and updates every dependency

mijorus commented 1 year ago

@dominikzogg are you willing to maintain this project in the long term?

dominikzogg commented 1 year ago

@mijorus its my first contact with flatpak development, not sure if i am skilled enough yet

mijorus commented 1 year ago

I'm sorry but if that's the case, there is no point merging your PR. Every time that Compass updates there is the possibility that something would not work or it wouldn't launch at all.

Unfortunately there is absolutely no support from the Mongo Compass team, maybe I shouldn't have made this wrapper in the first place.

Unless we find a stable maintainer, 1.37.0 will be the last release for this wrapper.

dominikzogg commented 1 year ago

@mijorus well if the choice is to abandon it or i'll try to maintain it i am for the last, cause i use compass on a daily base.

mijorus commented 1 year ago

@mijorus well if the choice is to abandon it or i'll try to maintain it i am for the last, cause i use compass on a daily base.

All right, I'll ask for a change of ownership later today, thank you.

mijorus commented 1 year ago

@dominikzogg a request has been sent this morning, I'll keep you updated

dominikzogg commented 1 year ago

@mijorus i am in. I am on vacation this week, so chances are, that i wil start next week.

mijorus commented 1 year ago

Can you merge the Pr?

dominikzogg commented 1 year ago

Done

dominikzogg commented 1 year ago

@mijorus what is needed to release it? I'll remove the EOL message when i am on a computer

mijorus commented 1 year ago

If you have write access to the repo, you just need to merge something into master to create a new release, everything happens automatically.

Remember that you can't push directly to master, but you need to open a PR first, let the bot build the app successfully and then merge it.

Also, there is an automated script that fetches the latest release from Compass, updates the json and opens a new pull request, like this: https://github.com/flathub/com.mongodb.Compass/pull/24

dominikzogg commented 1 year ago

@mijorus i tested and merged the PR for 1.38.2