flathub / com.nextcloud.desktopclient.nextcloud

https://flathub.org/apps/details/com.nextcloud.desktopclient.nextcloud
7 stars 18 forks source link

fix(theme): Disable broken gnome theme #130

Closed p-fruck closed 6 months ago

p-fruck commented 7 months ago

As QGnomePlatform is no longer maintained, the theme should be set to KDE by default. This fixes broken rendering on newer gnome desktops. fixes https://github.com/flathub/com.nextcloud.desktopclient.nextcloud/issues/115

flathubbot commented 7 months ago

Started test build 83241

flathubbot commented 7 months ago

Build 83241 failed

flathubbot commented 7 months ago

Started test build 86150

flathubbot commented 7 months ago

Build 86150 failed

flathubbot commented 7 months ago

Started test build 86151

flathubbot commented 7 months ago

Build 86151 successful To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/68813/com.nextcloud.desktopclient.nextcloud.flatpakref
pktiuk commented 6 months ago

@tilosp

julianfairfax commented 6 months ago

As QGnomePlatform is no longer maintained

Is there a way to stop flatpak from wanting to install it along with Nextcloud?

p-fruck commented 6 months ago

I am not sure about that but I think the QGnomePlatform is shipped with your Gnome Runtime until 39 and has been removed with Gnome 40. I think this flatpak does not affect QGnomePlatform presence on the installed system.

flathubbot commented 6 months ago

Started test build 89043

flathubbot commented 6 months ago

Build 89043 successful To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/71719/com.nextcloud.desktopclient.nextcloud.flatpakref
BryanMaker commented 5 months ago

By the way for those who don't want to reinstall but just want to repair their current installation. It is recommended to use the tool Flatseal (flatpak install flathub com.github.tchx84.Flatseal) to fix it, you just need to navigate to nextcloud then navigate to the environment variables section and add QT_QPA_PLATFORMTHEME=kde and then restart nextcloud

geez0x1 commented 5 months ago

For those that prefer the command line, a one-time command to fix this issue is sudo flatpak override --env=QT_QPA_PLATFORMTHEME=kde com.nextcloud.desktopclient.nextcloud

That said, it would be nice if the flatpak package could fix this for less tech-savvy users. Is there no way to add environment variables retroactively?

azuredusk10 commented 4 months ago

Running the command from @geez0x1 fixed the problem for me. Thanks! I'd always wondered what text was supposed to be in those empty spaces :joy:

I agree; I'd assumed that if this bug got fixed I'd receive the patch via a software update. I'm glad I stumbled across this thread but I imagine there are many users who are putting up with this, unaware that they would have to fix it manually. It did put me off recommending Nextcloud to my partner because parts of the app were unreadable.

slwr commented 2 months ago

For those that prefer the command line, a one-time command to fix this issue is sudo flatpak override --env=QT_QPA_PLATFORMTHEME=kde com.nextcloud.desktopclient.nextcloud

That said, it would be nice if the flatpak package could fix this for less tech-savvy users. Is there no way to add environment variables retroactively?

This workaround did the job in the past but for me it does not work any more.

Nextcloud GmbH - Nextcloud desktop synchronization client

          ID: com.nextcloud.desktopclient.nextcloud
         Ref: app/com.nextcloud.desktopclient.nextcloud/x86_64/stable
        Arch: x86_64
      Branch: stable
     Version: 3.12.3
     License: GPL-2.0+
      Origin: flathub
  Collection: org.flathub.Stable
Installation: system
   Installed: 186,3 MB
     Runtime: org.kde.Platform/x86_64/5.15-23.08
         Sdk: org.kde.Sdk/x86_64/5.15-23.08

      Commit: 8a4fd02cb3a8c7beca3e65c168b83255821201f0282695f38dc7ac632e8f510d
      Parent: 85e7ceb16107232af1b07cc4347d7aef0e5389f720bbb769b4347981b55c08fb
     Subject: Update desktop.git to 3.12.3 (7e914eaa)
        Date: 2024-03-28 16:41:25 +0000

I am using Arch Linux with GNOME:

gnome-autoar 0.4.4-1
gnome-backgrounds 46.0-1
gnome-bluetooth-3.0 46.0-1
gnome-calendar 46.1-2
gnome-characters 46.0-1
gnome-color-manager 3.36.0+r62+g82000f1d-1
gnome-console 46.0-2
gnome-contacts 46.0-1
gnome-control-center 46.1-2
gnome-desktop 1:44.0-1
gnome-desktop-4 1:44.0-1
gnome-desktop-common 1:44.0-1
gnome-disk-utility 46.0-1
gnome-keyring 1:46.1-2
gnome-logs 45.0-1
gnome-menus 3.36.0-2
gnome-online-accounts 3.50.1-1
gnome-session 46.0-1
gnome-settings-daemon 46.0-1
gnome-shell 1:46.1-1
gnome-shell-extension-gtile 59-1
gnome-system-monitor 46.0-1
xdg-desktop-portal-gnome 46.1-1
BigmenPixel0 commented 2 months ago

:arrow_up: The same problem on Fedora Workstation 40

azuredusk10 commented 2 months ago

My Nextcloud client has gone back to the bugged state with invisible text and icons: image

I'm on Fedora Workstation 40. I noticed this a few weeks back.

For those that prefer the command line, a one-time command to fix this issue is sudo flatpak override --env=QT_QPA_PLATFORMTHEME=kde com.nextcloud.desktopclient.nextcloud

That said, it would be nice if the flatpak package could fix this for less tech-savvy users. Is there no way to add environment variables retroactively?

Running this code again didn't fix the issue.

Trim commented 2 weeks ago

I've installed a fresh Debian 12 with nextcloud desktop from flathub.

I've seen too the previous override fix do not work anymore too.

As it's a freshed install, only nextcloud is using the KDE flatpak plateform, so I tried to remove all GNOME theme related KDE flatpak extensions:

$ sudo flatpak remove org.kde.PlatformTheme.QGnomePlatform org.kde.WaylandDecoration.QAdwaitaDecorations org.kde.WaylandDecoration.QGnomePlatform-decoration
Info: applications using the extension org.kde.WaylandDecoration.QGnomePlatform-decoration branch 5.15-23.08:
   com.nextcloud.desktopclient.nextcloud
Really remove? [y/n]: y
Info: applications using the extension org.kde.WaylandDecoration.QAdwaitaDecorations branch 5.15-23.08:
   com.nextcloud.desktopclient.nextcloud
Really remove? [y/n]: y
Info: applications using the extension org.kde.PlatformTheme.QGnomePlatform branch 5.15-23.08:
   com.nextcloud.desktopclient.nextcloud
Really remove? [y/n]: y

And after that it worked again. I think this is not a long-term solution as I expect that some future platform update or application installation will certainly take back these extensions.

For me it's ok to remove these extensions as I prefer to have working well applications rather than not-well adapted themes with my Desktop (see the https://stopthemingmy.app/ arguments which are proved to be true for this thread).

slwr commented 1 week ago

Issue still exists on my side:

I am not able to change what to synchronize.

OS: Arch Linux x86_64 Kernel: 6.9.6-arch1-1 DE: GNOME WM: Mutter WM Theme: Adwaita Theme: Adwaita-dark [GTK2/3] Icons: Adwaita [GTK2/3]

Trim commented 1 week ago

Issue still exists on my side:

For your information, I had to kill the nextcloud desktop process after I made these changes because the application stay in background if you just click the window close button.

azuredusk10 commented 1 week ago

Someone from Nextcloud has looked into the issue and believes the problem lies in the flatpak and potentially its libraries being out of date. Their comment: https://github.com/nextcloud/desktop/issues/5949#issuecomment-2189113365

p-fruck commented 1 week ago

Can confirm, seems to work fine with QT6 (see above PR). I think the kde runtime 5.15 for flatpak is just not updated anymore as QT5 is considered EOL

ironhak commented 1 week ago

For those that prefer the command line, a one-time command to fix this issue is sudo flatpak override --env=QT_QPA_PLATFORMTHEME=kde com.nextcloud.desktopclient.nextcloud

That said, it would be nice if the flatpak package could fix this for less tech-savvy users. Is there no way to add environment variables retroactively?

This does not work anymore.