search

flathub / com.obsproject.Studio

This repository is no longer used to build OBS. Issues should be reported at https://github.com/obsproject/obs-studio
https://github.com/obsproject/obs-studio
29 stars 19 forks source link

Fix v4l2loopback detection #100

Closed celebdor closed 3 years ago

celebdor commented 3 years ago

This Flatpak does not include modinfo and probably it is not necessary to include it just to detect if the module is there.

This patch also removes the reference to the v4lsink extension that as of 26.1 is no longer necessary

The issue of inserting the module still needs to be handled by the user separately. Until ostree has some support for dkms, the best is probably that the user builds it and has a systemd service that loads it on the multiuser target.

flathubbot commented 3 years ago

Started test build 39769

flathubbot commented 3 years ago

Build 39769 failed

celebdor commented 3 years ago

Related to #94

flathubbot commented 3 years ago

Started test build 40029

flathubbot commented 3 years ago

Build 40029 successful To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/38519/com.obsproject.Studio.flatpakref
celebdor commented 3 years ago

@TingPing @barthalion How does it look like?

GeorgesStavracas commented 3 years ago

I think recent versions of OBS Studio (as of Jan 25th) won't need this: https://github.com/obsproject/obs-studio/commit/d8a25ef94357d288d3a1f899efdaed889f02d5b1

I'm also working on moving the Wayland-compatible portal capture plugin upstream, now that all Wayland branches landed.

celebdor commented 3 years ago

Modinfo is not in our flatpak and using the host one would probably not work

GeorgesStavracas commented 3 years ago

If you look closely, loopback_module_loaded() does the same check you're doing here.

celebdor commented 3 years ago

Right. Thanks @GeorgesStavracas !