search

flathub / com.obsproject.Studio

This repository is no longer used to build OBS. Issues should be reported at https://github.com/obsproject/obs-studio
https://github.com/obsproject/obs-studio
29 stars 21 forks source link

[beta] Make VST plugins be found #126

Closed hfiguiere closed 3 years ago

hfiguiere commented 3 years ago

Allow OBS to find the VST plugins.

Caveat: UI won't display and I suspect it is because of Wayland will crash and that's because of Wayland. (I had tested with some plugins that display a blank UI)

I haven't checked the stable branch.

flathubbot commented 3 years ago

Started test build 45437

flathubbot commented 3 years ago

Build 45437 successful To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/43720/com.obsproject.Studio.flatpakref
GeorgesStavracas commented 3 years ago

Do you have a backtrace of the crash on Wayland?

hfiguiere commented 3 years ago

Basically the plugin expect an XWindow to show itself. It's not specific to OBS. The whole plugin system has ignored Wayland and the whole Wayland has ignored this use case.

X Error of failed request:  BadWindow (invalid Window parameter)
  Major opcode of failed request:  1 (X_CreateWindow)
  Resource id in failed request:  0x9
  Serial number of failed request:  54
  Current serial number in output stream:  56
terminate called without an active exception
hfiguiere commented 3 years ago

No problem with --nosocket=wayland

hfiguiere commented 3 years ago

It's possible to have OBS not crash though. Requires patching.

hfiguiere commented 3 years ago 
#0  0x00007ffff4c197f5 in raise () at /usr/lib/x86_64-linux-gnu/libc.so.6
#1  0x00007ffff4c02855 in abort () at /usr/lib/x86_64-linux-gnu/libc.so.6
#2  0x00007ffff4fdd7f1 in __gnu_cxx::__verbose_terminate_handler() [clone .cold] () at /usr/lib/x86_64-linux-gnu/libstdc++.so.6
#3  0x00007ffff4fe92ec in __cxxabiv1::__terminate(void (*)()) () at /usr/lib/x86_64-linux-gnu/libstdc++.so.6
#4  0x00007ffff4fe9357 in  () at /usr/lib/x86_64-linux-gnu/libstdc++.so.6
#5  0x00007fffb4759781 in  () at /app//lib/obs-plugins/obs-browser.so
#6  0x00007ffff4c1c1b7 in __run_exit_handlers () at /usr/lib/x86_64-linux-gnu/libc.so.6
#7  0x00007ffff4c1c360 in on_exit () at /usr/lib/x86_64-linux-gnu/libc.so.6
#8  0x00007ffff439044b in  () at /usr/lib/x86_64-linux-gnu/libX11.so.6
#9  0x00007ffff439055b in _XError () at /usr/lib/x86_64-linux-gnu/libX11.so.6
#10 0x00007ffff438d2c7 in handle_error () at /usr/lib/x86_64-linux-gnu/libX11.so.6
#11 0x00007ffff438d365 in handle_response () at /usr/lib/x86_64-linux-gnu/libX11.so.6
#12 0x00007ffff438e2ed in _XReply () at /usr/lib/x86_64-linux-gnu/libX11.so.6
#13 0x00007ffff4378688 in XInternAtom () at /usr/lib/x86_64-linux-gnu/libX11.so.6
#14 0x00007fff7611d4b4 in  () at /app/extensions/Plugins/lxvst/DISTRHO-Dexed.so
#15 0x00007fff7616b240 in  () at /app/extensions/Plugins/lxvst/DISTRHO-Dexed.so
#16 0x00007fff7616b6dd in  () at /app/extensions/Plugins/lxvst/DISTRHO-Dexed.so
#17 0x00007fff76165446 in  () at /app/extensions/Plugins/lxvst/DISTRHO-Dexed.so
#18 0x00007fff7611ef01 in  () at /app/extensions/Plugins/lxvst/DISTRHO-Dexed.so
#19 0x00007fff7606b291 in  () at /app/extensions/Plugins/lxvst/DISTRHO-Dexed.so
#20 0x00007fff75e19f20 in  () at /app/extensions/Plugins/lxvst/DISTRHO-Dexed.so
#21 0x00007fff75e1af70 in  () at /app/extensions/Plugins/lxvst/DISTRHO-Dexed.so
#22 0x00007fff75e196fd in  () at /app/extensions/Plugins/lxvst/DISTRHO-Dexed.so
#23 0x00007fff75e19b2e in  () at /app/extensions/Plugins/lxvst/DISTRHO-Dexed.so
#24 0x00007fffb44cff5b in EditorWidget::buildEffectContainer(AEffect*) () at /app//lib/obs-plugins/obs-vst.so
#25 0x00007fffb44cec52 in VSTPlugin::openEditor() () at /app//lib/obs-plugins/obs-vst.so
hfiguiere commented 3 years ago

It's possible to have OBS not crash though. Requires patching.

Or not since the XError comes from the plugin itself.

flathubbot commented 3 years ago

Started test build 48422

flathubbot commented 3 years ago

Build 48422 successful To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/46564/com.obsproject.Studio.flatpakref